Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1367)

Issue 1343883002: Revert of [Telemetry] Refactor Chrome devtools tracing (Closed)

Created:
5 years, 3 months ago by Zhen Wang
Modified:
5 years, 3 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Telemetry] Refactor Chrome devtools tracing (patchset #2 id:20001 of https://codereview.chromium.org/1338033002/ ) Reason for revert: This CL fails on mojo perf bots. For Chrome, Telemetry waits for Chrome for the devtools port number. But for mojo, telemetry gives the port number to mandoline. Revert for now, will work on a fix. See https://code.google.com/p/chromium/issues/detail?id=531755 Original issue's description: > [Telemetry] Refactor Chrome devtools tracing > > Platform-level tracing doc: > https://docs.google.com/document/d/1Uv8SzOq2ugvzLiOcP85g7qPiaxwsn4tgOdxpe3YjUkM/edit?usp=sharing > > BUG=515323 > > Committed: https://crrev.com/cbecca3af4042fbf593dead4c12cfdd22cfd2310 > Cr-Commit-Position: refs/heads/master@{#348740} TBR=nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=515323 Committed: https://crrev.com/df1e976e0ac698a96f062138404ea628c56efe1f Cr-Commit-Position: refs/heads/master@{#348782}

Patch Set 1 #

Messages

Total messages: 5 (0 generated)
Zhen Wang
Created Revert of [Telemetry] Refactor Chrome devtools tracing
5 years, 3 months ago (2015-09-15 00:02:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343883002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343883002/1
5 years, 3 months ago (2015-09-15 00:04:13 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-15 00:07:15 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/df1e976e0ac698a96f062138404ea628c56efe1f Cr-Commit-Position: refs/heads/master@{#348782}
5 years, 3 months ago (2015-09-15 00:07:51 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:39:52 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/df1e976e0ac698a96f062138404ea628c56efe1f
Cr-Commit-Position: refs/heads/master@{#348782}

Powered by Google App Engine
This is Rietveld 408576698