win: Add (currently unused) NTSTATUS_LOG

util/win/ntstatus_logging.cc

+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "util/win/ntstatus_logging.h"
+
+#include <string.h>

[Mark Mentovai, 2015/09/15 02:22:32]

<string>, no .h

[scottmg, 2015/09/15 04:33:51]

Done.

+
+#include "base/strings/stringprintf.h"
+
+namespace {
+
+std::string FormatNtstatus(DWORD ntstatus) {
+  char msgbuf[256];
+  DWORD flags = FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS |

[Mark Mentovai, 2015/09/15 02:22:32]

Optional: const, or write inline in the FormatMessageA()?

[scottmg, 2015/09/15 04:33:51]

Done.

+                FORMAT_MESSAGE_MAX_WIDTH_MASK | FORMAT_MESSAGE_FROM_HMODULE;
+  DWORD len = FormatMessageA(flags,
+                             GetModuleHandle(L"ntdll.dll"),
+                             ntstatus,
+                             0,
+                             msgbuf,
+                             arraysize(msgbuf),
+                             NULL);

[Mark Mentovai, 2015/09/15 02:22:32]

nullptr

[scottmg, 2015/09/15 04:33:51]

Done.

+  if (len) {
+    return msgbuf;
+  } else {
+    return base::StringPrintf("<failed to retrieve error message (0x%x)>",

[Mark Mentovai, 2015/09/15 02:22:32]

base/strings/stringprintf.h

[scottmg, 2015/09/15 04:33:51]

Already there?

+                              GetLastError());
+  }
+}
+
+}  // namespace
+
+namespace logging {
+
+NtstatusLogMessage::NtstatusLogMessage(const char* function,
+                                       const char* file_path,
+                                       int line,
+                                       LogSeverity severity,
+                                       DWORD ntstatus)
+    : LogMessage(function, file_path, line, severity), ntstatus_(ntstatus) {

[Mark Mentovai, 2015/09/15 02:22:32]

:(

mini_chromium has a function argument and Chromium doesn’t.

This will need to be an ugly thing like

#if defined(MINI_CHROMIUM_BASE_LOGGING_H_)
    function,
#endif

See https://user.git/mmentovai/bpoop/+/5032c36203f5/util/mach/mach_logging.cc
and .h. (Sorry for the internal link. This was the previous experimental-esque
repository from when Crashpad was called bpoop and was just my pet project on
the side. mach_logging originated in bpoop and I promoted it to base before
Crashpad became a real project.)

[scottmg, 2015/09/15 04:33:51]

Do you find the function in the log particularly useful? Maybe we should just
remove it for consistency.

I don't have access to that link I don't think, but done as suggested anyway.

[Mark Mentovai, 2015/09/15 12:52:57]

scottmg wrote:
I guess not. I used to use it, but not anymore. We can get rid of it, and
reintroduce it if we ever want it again.

What I liked about it was that in cases where things got inlined pretty deeply,
__FUNC__ would tell you the actual file that __LINE__ referred to, where
__FILE__ would always just tell you the translation unit.

+}
+
+NtstatusLogMessage::~NtstatusLogMessage() {
+  stream() << ": " << FormatNtstatus(ntstatus_)
+           << base::StringPrintf(" (0x%04x)", ntstatus_);

[Mark Mentovai, 2015/09/15 02:22:32]

According to https://msdn.microsoft.com/en-us/library/cc704588.aspx, NTSTATUS
uses all 32 bits, so 0x%08x?

[scottmg, 2015/09/15 04:33:51]

Done. (No idea what I was thinking there... 4 bytes maybe?)

+}
+
+}  // namespace logging