Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1343843002: .gn modification for http://crrev.com/1334963002, Blink public/BUILD.gn (Closed)

Created:
5 years, 3 months ago by mcasas
Modified:
5 years, 3 months ago
Reviewers:
Nico, brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

.gn modification for http://crrev.com/1334963002, Blink public/BUILD.gn BUG=530687 Committed: https://crrev.com/4337d5d343d87a6f0ee8c7f008c9c6dbc76fd3b3 Cr-Commit-Position: refs/heads/master@{#348749}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .gn View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 13 (4 generated)
mcasas
thakis@ PTAL (in connection with http://crrev.com/1334963002, I'll get an OWNER stamp later if it LGTY).
5 years, 3 months ago (2015-09-14 21:13:13 UTC) #2
Nico
https://codereview.chromium.org/1343843002/diff/1/.gn File .gn (right): https://codereview.chromium.org/1343843002/diff/1/.gn#newcode113 .gn:113: # discouraged except for gypi_to_gn calls. lgtm given that ...
5 years, 3 months ago (2015-09-14 21:15:29 UTC) #3
Nico
(ps: i removed one of your two =s in the bug line, so that rietveld ...
5 years, 3 months ago (2015-09-14 21:15:54 UTC) #4
mcasas
brettw@ Owners RS/ PTAL. (please note the mentioned CL justifying this patch).
5 years, 3 months ago (2015-09-14 21:17:49 UTC) #6
brettw
lgtm
5 years, 3 months ago (2015-09-14 21:30:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343843002/1
5 years, 3 months ago (2015-09-14 21:32:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 22:43:08 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/4337d5d343d87a6f0ee8c7f008c9c6dbc76fd3b3 Cr-Commit-Position: refs/heads/master@{#348749}
5 years, 3 months ago (2015-09-14 22:44:09 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:38:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4337d5d343d87a6f0ee8c7f008c9c6dbc76fd3b3
Cr-Commit-Position: refs/heads/master@{#348749}

Powered by Google App Engine
This is Rietveld 408576698