Abstract content::SessionStorageNamespace from core TabRestore code

Abstract content::SessionStorageNamespace from core TabRestore code

//content dependencies must be abstracted from core TabRestore code in
order for that code to be cleanly integrated on iOS. This CL tackles
the dependency on content::SessionStorageNamespace.

Currently, a TabRestoreService::Tab holds a scoped_refptr to the
content::SessionStorageNamespace associated with the WebContents from
which that Tab was created. This CL introduces the concept of
TabClientData, which is an object that is supplied to the Tab by the
TabRestoreServiceClient. Embedders may create subclasses of TabClientData,
which they can cast the TabClientData back to when they receive it
in their implementations of the relevant TabRestoreServiceDelegate methods.

This CL introduces a ContentTabClientData subclass that is a container for a
scoped_refptr<content::SessionStorageNamespace>, and changes //chrome-level
code to use ContentTabClientData to maintain the association between Tabs and
SessionStorageNamespaces.

BUG=530171
Committed: https://crrev.com/7f80ba17fa6d0dff158493f6d38554cb7e59c338
Cr-Commit-Position: refs/heads/master@{#349378}

[blundell, 2015-09-15 19:38:56]

blundell@chromium.org changed reviewers:
+ sky@chromium.org

[blundell, 2015-09-15 19:38:57]

https://codereview.chromium.org/1343833002/diff/80001/components/sessions/cor...
File components/sessions/core/tab_restore_service_client.h (right):

https://codereview.chromium.org/1343833002/diff/80001/components/sessions/cor...
components/sessions/core/tab_restore_service_client.h:44: class SESSIONS_EXPORT
TabClientData : public base::RefCounted<TabClientData> {
Note that this class needs to be refcounted because the Tab struct is copied and
assigned all over the place (I should probably put a comment to that effect in
the code...).

[sky, 2015-09-15 21:59:49]

https://codereview.chromium.org/1343833002/diff/80001/components/sessions/cor...
File components/sessions/core/tab_restore_service_client.h (right):

https://codereview.chromium.org/1343833002/diff/80001/components/sessions/cor...
components/sessions/core/tab_restore_service_client.h:44: class SESSIONS_EXPORT
TabClientData : public base::RefCounted<TabClientData> {
On 2015/09/15 19:38:57, blundell wrote:
> Note that this class needs to be refcounted because the Tab struct is copied
and
> assigned all over the place (I should probably put a comment to that effect in
> the code...).

I hate to propagate that. How about a Clone() method on TabClientData?

[blundell, 2015-09-16 11:53:51]

https://codereview.chromium.org/1343833002/diff/80001/components/sessions/cor...
File components/sessions/core/tab_restore_service_client.h (right):

https://codereview.chromium.org/1343833002/diff/80001/components/sessions/cor...
components/sessions/core/tab_restore_service_client.h:44: class SESSIONS_EXPORT
TabClientData : public base::RefCounted<TabClientData> {
On 2015/09/15 21:59:49, sky wrote:
> On 2015/09/15 19:38:57, blundell wrote:
> > Note that this class needs to be refcounted because the Tab struct is copied
> and
> > assigned all over the place (I should probably put a comment to that effect
in
> > the code...).
> 
> I hate to propagate that. How about a Clone() method on TabClientData?

Done.

[sky, 2015-09-16 19:54:14]

LGTM

[blundell, 2015-09-17 07:34:55]

The CQ bit was checked by blundell@chromium.org

[commit-bot: I haz the power, 2015-09-17 07:35:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1343833002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1343833002/100001

[commit-bot: I haz the power, 2015-09-17 08:06:05]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-09-17 08:07:07]

Patchset 6 (id:??) landed as
https://crrev.com/7f80ba17fa6d0dff158493f6d38554cb7e59c338
Cr-Commit-Position: refs/heads/master@{#349378}