Pass the mspdbsrv flag as a command line argument to the link wrapper.

Pass the mspdbsrv flag as a command line argument to the link wrapper.

This variable causes separate instances of mspdbsrv to be used
for each invocation of the linker.

Patch by sebmarchand@chromium.org.

R=scottmg@chromium.org

Committed: https://code.google.com/p/gyp/source/detail?r=1835

[Sébastien Marchand, 2014-01-10 18:08:23]

PTAL at this approach.

https://codereview.chromium.org/134383002/diff/30001/pylib/gyp/generator/ninj...
File pylib/gyp/generator/ninja.py (right):

https://codereview.chromium.org/134383002/diff/30001/pylib/gyp/generator/ninj...
pylib/gyp/generator/ninja.py:1615: 'True' if use_separate_mspdbsrv else
'False'))
I'm not satisfied with those 'True' and 'False' values, I've thought of
'multiple-mspdbsrv' and 'default-mspdbsrv' but I'm still not convinced... Do you
have a suggestion ?

[scottmg, 2014-01-10 19:47:50]

lgtm

https://codereview.chromium.org/134383002/diff/30001/pylib/gyp/generator/ninj...
File pylib/gyp/generator/ninja.py (right):

https://codereview.chromium.org/134383002/diff/30001/pylib/gyp/generator/ninj...
pylib/gyp/generator/ninja.py:1609: use_separate_mspdbsrv =
os.environ.get('GYP_USE_SEPARATE_MSPDBSRV') != None
maybe something like

int(os.environ.get('GYP_USE_SEPARATE_MSPDBSRV', '0')) != 0

would be better so that setting it "off" won't also cause it to be used.

https://codereview.chromium.org/134383002/diff/30001/pylib/gyp/generator/ninj...
pylib/gyp/generator/ninja.py:1615: 'True' if use_separate_mspdbsrv else
'False'))
On 2014/01/10 18:08:23, Sébastien Marchand wrote:
> I'm not satisfied with those 'True' and 'False' values, I've thought of
> 'multiple-mspdbsrv' and 'default-mspdbsrv' but I'm still not convinced... Do
you
> have a suggestion ?

I think %s of |use_separate_mspdbsrv| directly is fine.

[Sébastien Marchand, 2014-01-11 00:00:38]

Thanks, committing.

https://codereview.chromium.org/134383002/diff/30001/pylib/gyp/generator/ninj...
File pylib/gyp/generator/ninja.py (right):

https://codereview.chromium.org/134383002/diff/30001/pylib/gyp/generator/ninj...
pylib/gyp/generator/ninja.py:1609: use_separate_mspdbsrv =
os.environ.get('GYP_USE_SEPARATE_MSPDBSRV') != None
On 2014/01/10 19:47:51, scottmg wrote:
> maybe something like
> 
> int(os.environ.get('GYP_USE_SEPARATE_MSPDBSRV', '0')) != 0
> 
> would be better so that setting it "off" won't also cause it to be used.

Done.

https://codereview.chromium.org/134383002/diff/30001/pylib/gyp/generator/ninj...
pylib/gyp/generator/ninja.py:1615: 'True' if use_separate_mspdbsrv else
'False'))
On 2014/01/10 19:47:51, scottmg wrote:
> On 2014/01/10 18:08:23, Sébastien Marchand wrote:
> > I'm not satisfied with those 'True' and 'False' values, I've thought of
> > 'multiple-mspdbsrv' and 'default-mspdbsrv' but I'm still not convinced... Do
> you
> > have a suggestion ?
> 
> I think %s of |use_separate_mspdbsrv| directly is fine.

Done.

[Sébastien Marchand, 2014-01-11 00:08:31]

I've flipped the commit bit (I'm not a committer so I can't do otherwise) but
iirc there's no CQ for GYP and it should be manually uploaded by a committer...

[scottmg, 2014-01-11 00:23:45]

On 2014/01/11 00:08:31, Sébastien Marchand wrote:
> I've flipped the commit bit (I'm not a committer so I can't do otherwise) but
> iirc there's no CQ for GYP and it should be manually uploaded by a
committer...

Yup, I'll land it for you.

[scottmg, 2014-01-11 05:29:34]

https://codereview.chromium.org/134383002/diff/80001/pylib/gyp/generator/ninj...
File pylib/gyp/generator/ninja.py (right):

https://codereview.chromium.org/134383002/diff/80001/pylib/gyp/generator/ninj...
pylib/gyp/generator/ninja.py:1897: command=('%s gyp-win-tool link-wrapper $arch
'
oops, there's a "False " missing here. Added for landing.

[scottmg, 2014-01-11 05:51:52]

Committed patchset #3 manually as r1835 (presubmit successful).