Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1343773003: Revert of mandoline: Add back/forward support and UI. (Closed)

Created:
5 years, 3 months ago by Devlin
Modified:
5 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mandoline: Add back/forward support and UI. (patchset #9 id:160001 of https://codereview.chromium.org/1326443006/ ) Reason for revert: Broke Win x64 GN: FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/components/web_view/lib/url_request_cloneable.obj.rsp /c ../../components/web_view/url_request_cloneable.cc /Foobj/components/web_view/lib/url_request_cloneable.obj /Fdobj/components/web_view/lib_cc.pdb e:\b\build\slave\win_x64_gn\build\src\components\web_view\url_request_cloneable.cc(43) : error C2220: warning treated as error - no 'object' file generated e:\b\build\slave\win_x64_gn\build\src\components\web_view\url_request_cloneable.cc(43) : warning C4267: 'initializing' : conversion from 'size_t' to 'uint32_t', possible loss of data ninja: build stopped: subcommand failed. Original issue's description: > mandoline: Add back/forward support and UI. > > BUG=526268 > > Committed: https://crrev.com/f72ad72272047f3a1471de9f37e0cba7174ac0b0 > Cr-Commit-Position: refs/heads/master@{#348673} TBR=msw@chromium.org,sky@chromium.org,ben@chromium.org,erg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=526268 Committed: https://crrev.com/5848b22c1ecf06ade15bd6eda6d2ac4eab2b3a13 Cr-Commit-Position: refs/heads/master@{#348713}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -473 lines) Patch
D components/test/data/web_view/test_one.html View 1 chunk +0 lines, -1 line 0 comments Download
D components/test/data/web_view/test_three.html View 1 chunk +0 lines, -1 line 0 comments Download
A components/test/data/web_view/test_title_changed.html View 1 chunk +1 line, -0 lines 0 comments Download
D components/test/data/web_view/test_two.html View 1 chunk +0 lines, -1 line 0 comments Download
M components/web_view/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M components/web_view/public/interfaces/web_view.mojom View 3 chunks +0 lines, -10 lines 0 comments Download
M components/web_view/test_runner/test_runner_application_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M components/web_view/test_runner/test_runner_application_delegate.cc View 1 chunk +0 lines, -3 lines 0 comments Download
D components/web_view/url_request_cloneable.h View 1 chunk +0 lines, -53 lines 0 comments Download
D components/web_view/url_request_cloneable.cc View 1 chunk +0 lines, -60 lines 0 comments Download
M components/web_view/web_view_apptest.cc View 4 chunks +14 lines, -93 lines 0 comments Download
M components/web_view/web_view_impl.h View 4 chunks +1 line, -19 lines 0 comments Download
M components/web_view/web_view_impl.cc View 3 chunks +2 lines, -52 lines 0 comments Download
M mandoline/ui/desktop_ui/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_commands.h View 1 chunk +0 lines, -2 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.h View 6 chunks +12 lines, -9 lines 0 comments Download
M mandoline/ui/desktop_ui/browser_window.cc View 11 chunks +43 lines, -54 lines 0 comments Download
D mandoline/ui/desktop_ui/toolbar_view.h View 1 chunk +0 lines, -45 lines 0 comments Download
D mandoline/ui/desktop_ui/toolbar_view.cc View 1 chunk +0 lines, -55 lines 0 comments Download
M mandoline/ui/phone_ui/phone_browser_application_delegate.h View 1 chunk +0 lines, -2 lines 0 comments Download
M mandoline/ui/phone_ui/phone_browser_application_delegate.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Devlin
Created Revert of mandoline: Add back/forward support and UI.
5 years, 3 months ago (2015-09-14 20:37:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343773003/1
5 years, 3 months ago (2015-09-14 20:38:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 20:40:25 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5848b22c1ecf06ade15bd6eda6d2ac4eab2b3a13 Cr-Commit-Position: refs/heads/master@{#348713}
5 years, 3 months ago (2015-09-14 20:41:23 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:37:01 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5848b22c1ecf06ade15bd6eda6d2ac4eab2b3a13
Cr-Commit-Position: refs/heads/master@{#348713}

Powered by Google App Engine
This is Rietveld 408576698