Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Issue 1343773002: Compute outline mid-line in way that works with negative start-values (Closed)

Created:
5 years, 3 months ago by fs
Modified:
5 years, 3 months ago
Reviewers:
f(malita)
CC:
blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Compute outline mid-line in way that works with negative start-values Since the expression (x1+x2)/2 will always "round" towards zero, if one of the points (usually x1) is negative, the wrong "mid-line" will be computed, and as a result part of the outline will shift right/down. Instead compute the mid-line as x1+(x2-x1)/2 (or x1+thickness/2) i.e perform the division on something that is known to be non-negative and then offset from the starting point. (Similar reasoning for the other dimension.) BUG=529010 Committed: https://crrev.com/c6cb6e422ed0508bf1a283f31175bbd65e098178 git-svn-id: svn://svn.chromium.org/blink/trunk@202205 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -4 lines) Patch
A LayoutTests/fast/borders/outline-negative-start.html View 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/fast/borders/outline-negative-start-expected.html View 1 chunk +22 lines, -0 lines 0 comments Download
M Source/core/paint/ObjectPainter.cpp View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
5 years, 3 months ago (2015-09-14 15:23:40 UTC) #2
f(malita)
LGTM
5 years, 3 months ago (2015-09-14 15:29:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343773002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343773002/1
5 years, 3 months ago (2015-09-14 15:45:39 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202205
5 years, 3 months ago (2015-09-14 16:21:53 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:32:51 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6cb6e422ed0508bf1a283f31175bbd65e098178

Powered by Google App Engine
This is Rietveld 408576698