Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 1343743002: Remove dependency of PrefSyncableServiceFactory on //chrome. (Closed)

Created:
5 years, 3 months ago by sdefresne
Modified:
5 years, 3 months ago
CC:
cbentzel+watch_chromium.org, chromium-reviews, gab
Base URL:
https://chromium.googlesource.com/chromium/src.git@pref_service_syncable
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dependency of PrefSyncableServiceFactory on //chrome. Since CommandLinePrefStore will not be moved to syncable_prefs (as it is tied to the embedder) remove the dependency on it from the factory and instead requires the client to construct the instance. Change SetManagedPolicies/SetRecommendedPolicies to take the instance of policy::BrowserPolicyConnector to remove the dependency on BrowserProcess. Update client code after the API changes. BUG=522530 TBR=rdsmith@chromium.org Committed: https://crrev.com/98ccdc42061b5c6173a5800f260716bcb1d28b19 Cr-Commit-Position: refs/heads/master@{#348865}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -42 lines) Patch
M chrome/browser/net/ssl_config_service_manager_pref_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/prefs/chrome_pref_service_factory.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M chrome/browser/prefs/command_line_pref_store_proxy_unittest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/prefs/pref_service_syncable_factory.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/prefs/pref_service_syncable_factory.cc View 2 chunks +8 lines, -19 lines 0 comments Download
M chrome/browser/prefs/proxy_policy_unittest.cc View 2 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
sdefresne
Bernard, can you take a look? Gab, this if FYI.
5 years, 3 months ago (2015-09-14 14:11:46 UTC) #4
Bernhard Bauer
lgtm
5 years, 3 months ago (2015-09-14 14:30:34 UTC) #5
sdefresne
TBR-ing rdsmith@chromium.org for client code changed after API was modified with OWNERS approval chrome/browser/net/ssl_config_service_manager_pref_unittest.cc
5 years, 3 months ago (2015-09-15 09:29:15 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343743002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343743002/100001
5 years, 3 months ago (2015-09-15 09:29:23 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:100001)
5 years, 3 months ago (2015-09-15 10:27:43 UTC) #11
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/98ccdc42061b5c6173a5800f260716bcb1d28b19 Cr-Commit-Position: refs/heads/master@{#348865}
5 years, 3 months ago (2015-09-15 10:28:13 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:43:59 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/98ccdc42061b5c6173a5800f260716bcb1d28b19
Cr-Commit-Position: refs/heads/master@{#348865}

Powered by Google App Engine
This is Rietveld 408576698