Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 134373005: Mojo: Refactor PlatformChannel stuff. (Closed)

Created:
6 years, 11 months ago by viettrungluu
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Refactor PlatformChannel stuff. - Remove PlatformServerChannel/PlatformClientChannel. - Add PlatformChannelPair (move stuff formerly in PlatformServerChannel into this). It became apparent that my previous plan to make this work on Windows wasn't work nicely. On the one hand, on Vista+, we can basically make things work like POSIX (created the channels in the parent and connect them, and send a channel to a child). On the other, on XP, to be secure you need to do more work (the channels aren't connected or authenticated initially), so you'd need much more machinery (to wait for connection, to authenticate, etc.). So I'll go for a different mechanism to make things work on XP. The assumption from the Mojo embedder API will be that it's given a channel handle that's already been connected, authenticated, etc. (which will be taken care of by other means). This will add flexibility in other ways as well (e.g., make Mojo IPC more happily coexist with Chrome IPC -- you should be able to pass a handle over Chrome IPC to set up Mojo IPC). Still to do: Move PlatformChannelPair into its own files. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244223

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -186 lines) Patch
M mojo/common/test/multiprocess_test_base.h View 1 chunk +4 lines, -2 lines 0 comments Download
M mojo/common/test/multiprocess_test_base.cc View 5 chunks +15 lines, -14 lines 0 comments Download
M mojo/common/test/multiprocess_test_base_unittest.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M mojo/system/multiprocess_message_pipe_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M mojo/system/platform_channel.h View 3 chunks +44 lines, -56 lines 0 comments Download
M mojo/system/platform_channel.cc View 2 chunks +35 lines, -10 lines 0 comments Download
M mojo/system/platform_channel_posix.cc View 3 chunks +20 lines, -71 lines 0 comments Download
M mojo/system/raw_channel_posix_unittest.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M mojo/system/remote_message_pipe_posix_unittest.cc View 1 chunk +7 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 11 months ago (2014-01-10 19:20:13 UTC) #1
darin (slow to review)
LGTM
6 years, 11 months ago (2014-01-10 19:53:35 UTC) #2
viettrungluu
6 years, 11 months ago (2014-01-10 20:03:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r244223 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698