Return error to chrome.downloads.removeFile

content/browser/download/download_item_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // File method ordering: Methods in this file are in the same order as
 // in download_item_impl.h, with the following exception: The public
 // interface Start is placed in chronological order with the other
 // (private) routines that together define a DownloadItem's state
 // transitions as the download progresses.  See "Download progression
 // cascade" later in this file.
@@ skipping 598 matching lines @@
 }
 
 const std::string& DownloadItemImpl::GetHashState() const {
   return hash_state_;
 }
 
 bool DownloadItemImpl::GetFileExternallyRemoved() const {
   return file_externally_removed_;
 }
 
-void DownloadItemImpl::DeleteFile() {
+void DownloadItemImpl::DeleteFile(const base::Callback<void(bool)>& callback) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
   if ((GetState() != DownloadItem::COMPLETE) ||

[asanka, 2014/01/16 16:05:51]

Can you also check whether current_path_ is empty here? If so, assume success
since there's no download file.

[benjhayden, 2014/01/16 17:09:18]

Done.

       file_externally_removed_) {
     return;

[asanka, 2014/01/16 16:05:51]

You'll want to invoke the callback before returning.

[benjhayden, 2014/01/16 17:09:18]

Done.

   }
   BrowserThread::PostTaskAndReplyWithResult(
       BrowserThread::FILE, FROM_HERE,
       base::Bind(&DeleteDownloadedFile, current_path_),
-      base::Bind(&DownloadItemImpl::OnDownloadedFileRemoved,
-                 weak_ptr_factory_.GetWeakPtr()));
+      base::Bind(&DownloadItemImpl::DeleteFileDone,
+                 weak_ptr_factory_.GetWeakPtr(),
+                 callback));
   current_path_.clear();
 }
 
+void DownloadItemImpl::DeleteFileDone(
+    const base::Callback<void(bool)>& callback,
+    bool success) {
+  if (success) {

[asanka, 2014/01/16 16:05:51]

Nit: no braces

[benjhayden, 2014/01/16 17:09:18]

Done.

+    OnDownloadedFileRemoved();
+  }
+  callback.Run(success);
+}
+
 bool DownloadItemImpl::IsDangerous() const {
 #if defined(OS_WIN)
   // TODO(noelutz): At this point only the windows views UI supports
   // warnings based on dangerous content.
   return (danger_type_ == DOWNLOAD_DANGER_TYPE_DANGEROUS_FILE ||
           danger_type_ == DOWNLOAD_DANGER_TYPE_DANGEROUS_URL ||
           danger_type_ == DOWNLOAD_DANGER_TYPE_DANGEROUS_CONTENT ||
           danger_type_ == DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT ||
           danger_type_ == DOWNLOAD_DANGER_TYPE_DANGEROUS_HOST ||
           danger_type_ == DOWNLOAD_DANGER_TYPE_POTENTIALLY_UNWANTED);
@@ skipping 297 matching lines @@
 
   // Don't update observers. This method is expected to be called just before a
   // DownloadFile is created and Start() is called. The observers will be
   // notified when the download transitions to the IN_PROGRESS state.
 }
 
 void DownloadItemImpl::NotifyRemoved() {
   FOR_EACH_OBSERVER(Observer, observers_, OnDownloadRemoved(this));
 }
 
-void DownloadItemImpl::OnDownloadedFileRemoved(bool success) {
-  if (!success)
-    return;
+void DownloadItemImpl::OnDownloadedFileRemoved() {
   file_externally_removed_ = true;
   VLOG(20) << __FUNCTION__ << " download=" << DebugString(true);
   UpdateObservers();
 }
 
 base::WeakPtr<DownloadDestinationObserver>
 DownloadItemImpl::DestinationObserverAsWeakPtr() {
   return weak_ptr_factory_.GetWeakPtr();
 }
 
@@ skipping 799 matching lines @@
     case RESUME_MODE_USER_CONTINUE:
       return "USER_CONTINUE";
     case RESUME_MODE_USER_RESTART:
       return "USER_RESTART";
   }
   NOTREACHED() << "Unknown resume mode " << mode;
   return "unknown";
 }
 
 }  // namespace content