Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: gm/imagesource.cpp

Issue 1343703005: SkImageSource (Closed) Base URL: https://chromium.googlesource.com/skia.git@master
Patch Set: review comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gyp/effects.gypi » ('j') | include/effects/SkImageSource.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/imagesource.cpp
diff --git a/gm/bitmapsource.cpp b/gm/imagesource.cpp
similarity index 68%
copy from gm/bitmapsource.cpp
copy to gm/imagesource.cpp
index 155785b200b482bae46889beb230b25395a7628e..4e2ef7a645e9f434125f5165d8f721cf9100278e 100644
--- a/gm/bitmapsource.cpp
+++ b/gm/imagesource.cpp
@@ -7,24 +7,25 @@
#include "gm.h"
-#include "SkBitmapSource.h"
+#include "SkImage.h"
+#include "SkImageSource.h"
-// This GM exercises the SkBitmapSource ImageFilter class.
+// This GM exercises the SkImageSource ImageFilter class.
-class BitmapSourceGM : public skiagm::GM {
+class ImageSourceGM : public skiagm::GM {
public:
- BitmapSourceGM() {
- }
+ ImageSourceGM() { }
protected:
SkString onShortName() override {
- return SkString("bitmapsource");
+ return SkString("imagesource");
}
SkISize onISize() override { return SkISize::Make(500, 150); }
void onOnceBeforeDraw() override {
- fBitmap = sk_tool_utils::create_string_bitmap(100, 100, 0xFFFFFFFF, 20, 70, 96, "e");
+ SkBitmap bm = sk_tool_utils::create_string_bitmap(100, 100, 0xFFFFFFFF, 20, 70, 96, "e");
+ fImage.reset(SkImage::NewFromBitmap(bm));
}
static void FillRectFiltered(SkCanvas* canvas, const SkRect& clipRect, SkImageFilter* filter) {
@@ -42,12 +43,14 @@ protected:
SkRect srcRect = SkRect::MakeXYWH(20, 20, 30, 30);
SkRect dstRect = SkRect::MakeXYWH(0, 10, 60, 60);
SkRect clipRect = SkRect::MakeXYWH(0, 0, 100, 100);
- SkRect bounds;
- fBitmap.getBounds(&bounds);
- SkAutoTUnref<SkImageFilter> bitmapSource(SkBitmapSource::Create(fBitmap));
- SkAutoTUnref<SkImageFilter> bitmapSourceSrcRect(SkBitmapSource::Create(fBitmap, srcRect, srcRect));
- SkAutoTUnref<SkImageFilter> bitmapSourceSrcRectDstRect(SkBitmapSource::Create(fBitmap, srcRect, dstRect));
- SkAutoTUnref<SkImageFilter> bitmapSourceDstRectOnly(SkBitmapSource::Create(fBitmap, bounds, dstRect));
+ SkRect bounds = SkRect::MakeIWH(fImage->width(), fImage->height());
+ SkAutoTUnref<SkImageFilter> bitmapSource(SkImageSource::Create(fImage));
Stephen White 2015/09/14 19:49:24 uNit: bitmapSource -> imageSource?
f(malita) 2015/09/14 20:07:19 Done.
+ SkAutoTUnref<SkImageFilter> bitmapSourceSrcRect(
+ SkImageSource::Create(fImage, srcRect, srcRect, kHigh_SkFilterQuality));
+ SkAutoTUnref<SkImageFilter> bitmapSourceSrcRectDstRect(
+ SkImageSource::Create(fImage, srcRect, dstRect, kHigh_SkFilterQuality));
+ SkAutoTUnref<SkImageFilter> bitmapSourceDstRectOnly(
+ SkImageSource::Create(fImage, bounds, dstRect, kHigh_SkFilterQuality));
// Draw an unscaled bitmap.
FillRectFiltered(canvas, clipRect, bitmapSource);
@@ -68,10 +71,10 @@ protected:
}
private:
- SkBitmap fBitmap;
+ SkAutoTUnref<SkImage> fImage;
typedef GM INHERITED;
};
///////////////////////////////////////////////////////////////////////////////
-DEF_GM( return new BitmapSourceGM; )
+DEF_GM( return new ImageSourceGM; )
« no previous file with comments | « no previous file | gyp/effects.gypi » ('j') | include/effects/SkImageSource.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698