SkImageSource

include/effects/SkImageSource.h

+/*
+ * Copyright 2015 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#ifndef SkImageSource_DEFINED
+#define SkImageSource_DEFINED
+
+#include "SkImageFilter.h"
+
+class SkImage;
+
+class SK_API SkImageSource : public SkImageFilter {
+public:
+    static SkImageSource* Create(const SkImage*);
+    static SkImageSource* Create(const SkImage*,
+                                 const SkRect& srcRect,
+                                 const SkRect& dstRect,
+                                 SkFilterQuality = kHigh_SkFilterQuality);

[Stephen White, 2015/09/14 18:39:27]

API Q for reed@: since we have the chance, should we get rid of the default
param here?

It will require explicitly choosing one in Blink where we don't currently, but
maybe that's a good thing.

[f(malita), 2015/09/14 19:19:35]

Up to reed@, but SGTM. Updated.

+
+    void computeFastBounds(const SkRect& src, SkRect* dst) const override;
+
+    SK_TO_STRING_OVERRIDE()
+    SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkImageSource)
+
+protected:
+    void flatten(SkWriteBuffer&) const override;
+
+    bool onFilterImage(Proxy*, const SkBitmap& src, const Context&,
+                       SkBitmap* result, SkIPoint* offset) const override;
+
+private:
+    explicit SkImageSource(const SkImage*);
+    explicit SkImageSource(const SkImage*,

[Stephen White, 2015/09/14 18:39:27]

Nit: explicit is unnecessary here?

[f(malita), 2015/09/14 19:19:35]

Done.

+                           const SkRect& srcRect,
+                           const SkRect& dstRect,
+                           SkFilterQuality);
+
+    SkAutoTUnref<const SkImage> fImage;
+    SkRect                      fSrcRect, fDstRect;
+    SkFilterQuality             fFilterQuality;
+
+    typedef SkImageFilter INHERITED;
+};
+
+#endif