Issue 134363002: Revert of Delete all invalidated resources with same key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 134363002: Revert of Delete all invalidated resources with same key (Closed)

Created:
6 years, 11 months ago by mtklein

Modified:
6 years, 11 months ago

Reviewers:
Kimmo Kinnunen

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Revert of https://codereview.chromium.org/106563002/ Reason for revert: There's a threading issue I don't quite understand yet. Objects are being deleted after we check they're deleted. Will try again. TBR=kkinnunen@nvidia.com,kkinnunen@nvidia.com NOTREECHECKS=true NOTRY=true Committed: http://code.google.com/p/skia/source/detail?r=13023

Created: 6 years, 11 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -77 lines)			Patch
	M	src/gpu/GrResourceCache.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	tests/ResourceCacheTest.cpp	View		3 chunks	+0 lines, -75 lines	0 comments	Download

Total messages: 3 (0 generated)

mtklein

Created Revert of Delete all invalidated resources with same key

6 years, 11 months ago (2014-01-10 17:58:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@google.com/134363002/1

6 years, 11 months ago (2014-01-10 17:58:27 UTC) #2

Message was sent while issue was closed.

Change committed as 13023