Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 13436003: Fix FakeDriveService's behavior to be more correct. (Closed)

Created:
7 years, 8 months ago by kinaba
Modified:
7 years, 8 months ago
Reviewers:
hidehiko
CC:
chromium-reviews, achuith+watch_chromium.org
Visibility:
Public.

Description

Fix FakeDriveService's behavior to be more correct. The current implementation works correctly only for the tested cases. This patch fixes the following broken cases. - Uploading a new file to the root collection - Uploading onto an existing file without caring etag. BUG=225649 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=191799

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/google_apis/fake_drive_service.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kinaba
ptal. I want to include this, for using real DriveUploader instead of FakeUploader in DriveFileSystemTest, ...
7 years, 8 months ago (2013-04-02 05:11:30 UTC) #1
hidehiko
lgtm
7 years, 8 months ago (2013-04-02 05:15:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/13436003/1
7 years, 8 months ago (2013-04-02 05:33:36 UTC) #3
kinaba
7 years, 8 months ago (2013-04-02 07:53:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r191799 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698