Cleanup code in printing/

printing/emf_win_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "printing/emf_win.h"
 
 // For quick access.
 #include <wingdi.h>
 #include <winspool.h>
 
@@ skipping 27 matching lines @@
       return true;
     DeleteDC(hdc);
     return false;
   }
 
   // PrintingContext::Delegate methods.
   gfx::NativeView GetParentView() override { return NULL; }
   std::string GetAppLocale() override { return std::string(); }
 };
 
-const uint32 EMF_HEADER_SIZE = 128;
+const uint32_t EMF_HEADER_SIZE = 128;
+const int ONE_MB = 1024 * 1024;
 
 }  // namespace
 
 TEST(EmfTest, DC) {
   // Simplest use case.
-  uint32 size;
+  uint32_t size;
   std::vector<char> data;
   {
     Emf emf;
     EXPECT_TRUE(emf.Init());
     EXPECT_TRUE(emf.context() != NULL);
     // An empty EMF is invalid, so we put at least a rectangle in it.
     ::Rectangle(emf.context(), 10, 10, 190, 190);
     EXPECT_TRUE(emf.FinishDocument());
     size = emf.GetDataSize();
     EXPECT_GT(size, EMF_HEADER_SIZE);
@@ skipping 61 matching lines @@
   context->PageDone();
   context->DocumentDone();
 }
 
 // Disabled if no "UnitTest printer" exists.
 TEST_F(EmfPrintingTest, PageBreak) {
   base::win::ScopedCreateDC dc(
       CreateDC(L"WINSPOOL", L"UnitTest Printer", NULL, NULL));
   if (!dc.Get())
     return;
-  uint32 size;
+  uint32_t size;
   std::vector<char> data;
   {
     Emf emf;
     EXPECT_TRUE(emf.Init());
     EXPECT_TRUE(emf.context() != NULL);
     int pages = 3;
     while (pages) {
       EXPECT_TRUE(emf.StartPage(gfx::Size(), gfx::Rect(), 1));
       ::Rectangle(emf.context(), 10, 10, 190, 190);
       EXPECT_TRUE(emf.FinishPage());
@@ skipping 24 matching lines @@
   }
 }
 
 TEST(EmfTest, FileBackedEmf) {
   // Simplest use case.
   base::ScopedTempDir scratch_metafile_dir;
   ASSERT_TRUE(scratch_metafile_dir.CreateUniqueTempDir());
   base::FilePath metafile_path;
   EXPECT_TRUE(base::CreateTemporaryFileInDir(scratch_metafile_dir.path(),
                                              &metafile_path));
-  uint32 size;
+  uint32_t size;
   std::vector<char> data;
   {
     Emf emf;
     EXPECT_TRUE(emf.InitToFile(metafile_path));
     EXPECT_TRUE(emf.context() != NULL);
     // An empty EMF is invalid, so we put at least a rectangle in it.
     ::Rectangle(emf.context(), 10, 10, 190, 190);
     EXPECT_TRUE(emf.FinishDocument());
     size = emf.GetDataSize();
     EXPECT_GT(size, EMF_HEADER_SIZE);
     EXPECT_TRUE(emf.GetDataAsVector(&data));
     EXPECT_EQ(data.size(), size);
   }
-  int64 file_size = 0;
+  int64_t file_size = 0;
   base::GetFileSize(metafile_path, &file_size);
   EXPECT_EQ(size, file_size);
 
   // Playback the data.
   HDC hdc = CreateCompatibleDC(NULL);
   EXPECT_TRUE(hdc);
   Emf emf;
   EXPECT_TRUE(emf.InitFromFile(metafile_path));
   RECT output_rect = {0, 0, 10, 10};
   EXPECT_TRUE(emf.Playback(hdc, &output_rect));
@@ skipping 11 matching lines @@
   }
   EXPECT_TRUE(emf.FinishDocument());
 
   scoped_ptr<Emf> raster(emf.RasterizeMetafile(1));
   // Just 1px bitmap but should be stretched to the same bounds.
   EXPECT_EQ(emf.GetPageBounds(1), raster->GetPageBounds(1));
 
   raster = emf.RasterizeMetafile(20);
   EXPECT_EQ(emf.GetPageBounds(1), raster->GetPageBounds(1));
 
-  raster = emf.RasterizeMetafile(16 * 1024 * 1024);
+  raster = emf.RasterizeMetafile(16 * ONE_MB);
   // Expected size about 64MB.
-  EXPECT_LE(abs(int(raster->GetDataSize()) - 64 * 1024 * 1024), 1024 * 1024);
+  EXPECT_LE(abs(static_cast<int>(raster->GetDataSize()) - 64 * ONE_MB), ONE_MB);
   // Bounds should still be the same.
   EXPECT_EQ(emf.GetPageBounds(1), raster->GetPageBounds(1));
 }
 
 }  // namespace printing