Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1343593002: Cleanup code in printing/ (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup code in printing/ - Use stdint.h types. - Fix lint errors. Committed: https://crrev.com/707a24b2c4e94bf8050a5d2ec2394998c21a80a8 Cr-Commit-Position: refs/heads/master@{#348660}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -58 lines) Patch
M printing/emf_win.h View 2 chunks +3 lines, -3 lines 0 comments Download
M printing/emf_win.cc View 6 chunks +11 lines, -9 lines 0 comments Download
M printing/emf_win_unittest.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M printing/image.h View 2 chunks +5 lines, -5 lines 0 comments Download
M printing/image.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M printing/image_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/image_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M printing/metafile.h View 2 chunks +4 lines, -3 lines 0 comments Download
M printing/metafile.cc View 1 chunk +2 lines, -1 line 0 comments Download
M printing/pdf_metafile_cg_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download
M printing/pdf_metafile_cg_mac.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M printing/pdf_metafile_cg_mac_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M printing/pdf_metafile_skia.h View 2 chunks +3 lines, -3 lines 0 comments Download
M printing/pdf_metafile_skia.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M printing/print_settings_initializer_mac.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
Lei Zhang
5 years, 3 months ago (2015-09-13 02:50:17 UTC) #2
Vitaly Buka (NO REVIEWS)
lgtm
5 years, 3 months ago (2015-09-14 16:30:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343593002/1
5 years, 3 months ago (2015-09-14 16:30:47 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/62406) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 3 months ago (2015-09-14 16:56:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343593002/1
5 years, 3 months ago (2015-09-14 17:10:30 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 18:16:43 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/707a24b2c4e94bf8050a5d2ec2394998c21a80a8 Cr-Commit-Position: refs/heads/master@{#348660}
5 years, 3 months ago (2015-09-14 18:17:23 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:34:32 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/707a24b2c4e94bf8050a5d2ec2394998c21a80a8
Cr-Commit-Position: refs/heads/master@{#348660}

Powered by Google App Engine
This is Rietveld 408576698