Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 1343553003: permissions: make ProtectedMediaIdentiferInfoBarDelegate a subclass of PermissionInfobarDelegate (Closed)

Created:
5 years, 3 months ago by Lalit Maganti
Modified:
5 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, mcasas+watch_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

permissions: make ProtectedMediaIdentiferInfoBarDelegate a subclass of PermissionInfobarDelegate There was a lot of code duplication and a TODO to fix this. Doing it now saves a bunch of work in future CLs. BUG=266743, 516626 Committed: https://crrev.com/6d73ba67dcf662ad681d17fa6f929e7996382d45 Cr-Commit-Position: refs/heads/master@{#349129}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -67 lines) Patch
M chrome/app/generated_resources.grd View 1 2 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/media/protected_media_identifier_infobar_delegate.h View 2 chunks +3 lines, -17 lines 0 comments Download
M chrome/browser/media/protected_media_identifier_infobar_delegate.cc View 3 chunks +5 lines, -42 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (7 generated)
Lalit Maganti
Mounir: PTAL so I can send to owners.
5 years, 3 months ago (2015-09-15 13:54:15 UTC) #2
mlamouri (slow - plz ping)
lgtm https://codereview.chromium.org/1343553003/diff/1/chrome/browser/media/protected_media_identifier_infobar_delegate.h File chrome/browser/media/protected_media_identifier_infobar_delegate.h (left): https://codereview.chromium.org/1343553003/diff/1/chrome/browser/media/protected_media_identifier_infobar_delegate.h#oldcode18 chrome/browser/media/protected_media_identifier_infobar_delegate.h:18: // http://crbug.com/266743 Link that CL to 266743. Probably ...
5 years, 3 months ago (2015-09-15 14:04:16 UTC) #3
Lalit Maganti
tommi@: can you please take a look?
5 years, 3 months ago (2015-09-15 14:24:09 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343553003/1
5 years, 3 months ago (2015-09-15 17:17:03 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 18:14:56 UTC) #9
mlamouri (slow - plz ping)
Jochen, by any chance, do you feel comfortable reviewing this?
5 years, 3 months ago (2015-09-16 14:00:06 UTC) #11
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-16 14:01:34 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343553003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343553003/20001
5 years, 3 months ago (2015-09-16 14:05:57 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-16 15:23:52 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/6d73ba67dcf662ad681d17fa6f929e7996382d45 Cr-Commit-Position: refs/heads/master@{#349129}
5 years, 3 months ago (2015-09-16 15:24:38 UTC) #17
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:56:00 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6d73ba67dcf662ad681d17fa6f929e7996382d45
Cr-Commit-Position: refs/heads/master@{#349129}

Powered by Google App Engine
This is Rietveld 408576698