Returning back from any app [after share via] is creating a black screen

Returning back from any app [after share via] is creating a black screen

When the surfaceView is destroyed during compositing, ContentViewRenderView
can't receive the message. So, the onSwapBuffers event will not occurs, and the
value of mPendingSwapBuffers will increasing without bound.

To prevent the problem, currently, the value is initialized in onReadyToRender
method. However, content_shell and chromium_test_shell override the method and
don't call super method.

BUG=337770
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=247525

[zino, 2014-01-24 09:00:18]

https://code.google.com/p/chromium/issues/detail?id=337770

Steps to reproduce the problem:
1. Launch Browser
2. Access any page like cnn.com
3. Long tap on any text to select the text
4. From the pop up choose the Share via option
5. Choose Gmail option (no popup app)
6. Tap the back key to come to the Browser
7. Repeat from 3 to 6 (exactly three times)

Thank you.

[Ken Russell (switch to Gerrit), 2014-01-24 23:09:45]

+aelias

[aelias_OOO_until_Jul13, 2014-01-24 23:49:08]

sievers@ should take a look at this.  Would calling onReadyToRender from the
subclasses be a better fix perhaps?

[zino, 2014-01-25 04:58:55]

On 2014/01/24 23:49:08, aelias wrote:
> sievers@ should take a look at this.  Would calling onReadyToRender from the
> subclasses be a better fix perhaps?

I can see your point of view but I think differently.
In that case, We have to force that override method always calls super method.
(such as android.app.SuperNotCalledException)
The init code is common. Also, the codes must be execute.
But we can skip calling super method in override method currently.
If derived class is increased, it may occur same problem.

[commit-bot: I haz the power, 2014-01-27 00:30:37]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[zino, 2014-01-28 01:31:56]

Please review this patch.

[no sievers, 2014-01-28 01:52:48]

lgtm

[commit-bot: I haz the power, 2014-01-28 04:07:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/134353004/1

[commit-bot: I haz the power, 2014-01-28 04:44:35]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2014-01-28 06:14:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/134353004/1

[commit-bot: I haz the power, 2014-01-28 06:34:38]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[jdduke (slow), 2014-01-28 16:13:43]

lgtm

[commit-bot: I haz the power, 2014-01-28 21:29:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jinho.bang@samsung.com/134353004/1

[commit-bot: I haz the power, 2014-01-28 23:46:41]

Change committed as 247525