When rendering offscreen, prefer size 0 instead of 1.

services/gles2/command_buffer_driver.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/gles2/command_buffer_driver.h"
 
 #include "base/bind.h"
 #include "base/macros.h"
 #include "base/memory/shared_memory.h"
 #include "gpu/command_buffer/common/constants.h"
@@ skipping 81 matching lines @@
   loss_observer_ = loss_observer.Pass();
   bool success = DoInitialize(shared_state.Pass());
   mojo::GpuCapabilitiesPtr capabilities =
       success ? mojo::GpuCapabilities::From(decoder_->GetCapabilities())
               : mojo::GpuCapabilities::New();
   sync_client_->DidInitialize(success, capabilities.Pass());
 }
 
 bool CommandBufferDriver::DoInitialize(
     mojo::ScopedSharedBufferHandle shared_state) {
-  if (widget_ == gfx::kNullAcceleratedWidget)
+  if (widget_ == gfx::kNullAcceleratedWidget) {
+    // This is a dummy surface, so attempt to skip actual surface
+    // allocation by passing size 0.
     surface_ = gfx::GLSurface::CreateOffscreenGLSurface(
+        gfx::Size(0, 0), requested_configuration_);
+    if (!surface_)

[jamesr, 2015/09/11 21:34:59]

add { }s since the body of this conditional is multiline. maybe comment here
indicating why the code is retrying with 1x1

[cdotstout, 2015/09/11 21:52:54]

Done.

+      surface_ = gfx::GLSurface::CreateOffscreenGLSurface(
         gfx::Size(1, 1), requested_configuration_);

[jamesr, 2015/09/11 21:34:59]

i think indentation is now wrong on this line

[cdotstout, 2015/09/11 21:52:54]

Done.

-  else {
+  } else {
     surface_ =
         gfx::GLSurface::CreateViewGLSurface(widget_, requested_configuration_);
     if (auto vsync_provider = surface_->GetVSyncProvider()) {
       vsync_provider->GetVSyncParameters(
           base::Bind(&CommandBufferDriver::OnUpdateVSyncParameters,
                      weak_factory_.GetWeakPtr()));
     }
   }
 
   if (!surface_.get())
@@ skipping 131 matching lines @@
   client_->DidLoseContext();
 }
 
 void CommandBufferDriver::OnUpdateVSyncParameters(
     const base::TimeTicks timebase,
     const base::TimeDelta interval) {
   client_->UpdateVSyncParameters(timebase, interval);
 }
 
 }  // namespace gles2