win: Don't run x64 specific test unless built for x64

util/win/process_info_test.cc

Index: util/win/process_info_test.cc
diff --git a/util/win/process_info_test.cc b/util/win/process_info_test.cc
index 76ecb4a603b303bf135b899cd68572a90a45ed1e..de4bbabcade23a35a36acfdfd908e632d03f777c 100644
--- a/util/win/process_info_test.cc
+++ b/util/win/process_info_test.cc
@@ -161,9 +161,14 @@ void TestOtherProcess(const std::wstring& child_name_suffix) {
                                        wcslen(kLz32dllName)));
 }
 
+// This test can't run the child if the host OS is x86, and can't read from the
+// child if it is x86 and the child is x64, so it only makes sense to run this

[Mark Mentovai, 2015/09/11 22:40:58]

“can’t read from the child if it is x86 and the child is x64”

because of no Crashpad support or no Windows support?

[scottmg, 2015/09/11 22:45:51]

A bit of both. There's undocumented equivalents to ReadProcessMemory that can
read x64 from x86 but I think it'll get messy quickly, as it adds to the WOW64
permutations. I don't think it's too useful for Crashpad to support an x86 crash
handler reading x64 processes in any case?

[Mark Mentovai, 2015/09/11 22:51:17]

Maybe not useful, but interesting, and if it’s just ReadProcessMemory(), it
should be reasonably self-contained. (And we’ve already got the WinVMAddress
type, so most of our code should already be ready for it from the address-width
perspective.)

I’m not saying that I really need to see it supported, although I’d personally
consider it fun, and it might make us more resilient and allow us to catch
crashes from the small number of users with the weird cross-bitted installs that
we’ll inevitably see. (How likely this is depends on whether Crashpad and Chrome
can wind up coming from different places, but I’m a little scarred by the
Chrome-Omaha versioning nightmare.)

+// if we built as x64.
+#if defined(ARCH_CPU_64_BITS)
 TEST(ProcessInfo, OtherProcessX64) {
   TestOtherProcess(L"x64");
 }
+#endif  // ARCH_CPU_64_BITS
 
 TEST(ProcessInfo, OtherProcessX86) {
   TestOtherProcess(L"x86");