Source/core/editing/ReplaceSelectionCommand.h - Issue 134343002: Update editing classes to use OVERRIDE / FINAL when needed

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/ReplaceSelectionCommand.h

Issue 134343002: Update editing classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/editing/RemoveCSSPropertyCommand.h ('K') | « Source/core/editing/ReplaceNodeWithSpanCommand.h ('k') | Source/core/editing/SetNodeAttributeCommand.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/ReplaceSelectionCommand.h

diff --git a/Source/core/editing/ReplaceSelectionCommand.h b/Source/core/editing/ReplaceSelectionCommand.h

index ee3879b22588302654f7274113164c24e4dbca55..46421e12d85f4bb800ea09cbb24157dc7121b9af 100644

--- a/Source/core/editing/ReplaceSelectionCommand.h

+++ b/Source/core/editing/ReplaceSelectionCommand.h

@@ -34,7 +34,7 @@ namespace WebCore {

class DocumentFragment;

class ReplacementFragment;

-class ReplaceSelectionCommand : public CompositeEditCommand {

+class ReplaceSelectionCommand FINAL : public CompositeEditCommand {

public:

enum CommandOption {

SelectReplacement = 1 << 0,

@@ -55,8 +55,8 @@ public:

private:

ReplaceSelectionCommand(Document&, PassRefPtr<DocumentFragment>, CommandOptions, EditAction);

- virtual void doApply();

- virtual EditAction editingAction() const;

+ virtual void doApply() OVERRIDE;

+ virtual EditAction editingAction() const OVERRIDE;

class InsertedNodes {

public: