Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(776)

Unified Diff: Source/core/editing/CompositeEditCommand.h

Issue 134343002: Update editing classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/editing/CompositeEditCommand.h
diff --git a/Source/core/editing/CompositeEditCommand.h b/Source/core/editing/CompositeEditCommand.h
index d1eaa968938d214babc91e9f18a6b08543e26d56..175b42670a3290545c0df07e5c238b9d27d7c88f 100644
--- a/Source/core/editing/CompositeEditCommand.h
+++ b/Source/core/editing/CompositeEditCommand.h
@@ -38,14 +38,14 @@ class Element;
class HTMLElement;
class Text;
-class EditCommandComposition : public UndoStep {
+class EditCommandComposition FINAL : public UndoStep {
public:
static PassRefPtr<EditCommandComposition> create(Document*, const VisibleSelection&, const VisibleSelection&, EditAction);
virtual bool belongsTo(const Frame&) const OVERRIDE;
virtual void unapply() OVERRIDE;
virtual void reapply() OVERRIDE;
- EditAction editingAction() const OVERRIDE { return m_editAction; }
+ virtual EditAction editingAction() const OVERRIDE { return m_editAction; }
void append(SimpleEditCommand*);
bool wasCreateLinkCommand() const { return m_editAction == EditActionCreateLink; }
@@ -168,7 +168,7 @@ protected:
Vector<RefPtr<EditCommand> > m_commands;
private:
- bool isCompositeEditCommand() const OVERRIDE { return true; }
+ bool isCompositeEditCommand() const OVERRIDE FINAL { return true; }
eseidel 2014/01/10 18:24:14 The whole class is final, no?
Inactive 2014/01/10 18:36:00 No, the CompositeEditCommand class is not FINAL. I
RefPtr<EditCommandComposition> m_composition;
};

Powered by Google App Engine
This is Rietveld 408576698