Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: Source/core/editing/FormatBlockCommand.h

Issue 134343002: Update editing classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2006, 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 20 matching lines...) Expand all
31 #include "core/editing/EditAction.h" 31 #include "core/editing/EditAction.h"
32 32
33 namespace WebCore { 33 namespace WebCore {
34 34
35 class Document; 35 class Document;
36 class Element; 36 class Element;
37 class Position; 37 class Position;
38 class Range; 38 class Range;
39 class VisiblePosition; 39 class VisiblePosition;
40 40
41 class FormatBlockCommand : public ApplyBlockElementCommand { 41 class FormatBlockCommand FINAL : public ApplyBlockElementCommand {
42 public: 42 public:
43 static PassRefPtr<FormatBlockCommand> create(Document& document, const Quali fiedName& tagName) 43 static PassRefPtr<FormatBlockCommand> create(Document& document, const Quali fiedName& tagName)
44 { 44 {
45 return adoptRef(new FormatBlockCommand(document, tagName)); 45 return adoptRef(new FormatBlockCommand(document, tagName));
46 } 46 }
47 47
48 virtual bool preservesTypingStyle() const { return true; } 48 virtual bool preservesTypingStyle() const OVERRIDE { return true; }
49 49
50 static Element* elementForFormatBlockCommand(Range*); 50 static Element* elementForFormatBlockCommand(Range*);
51 bool didApply() const { return m_didApply; } 51 bool didApply() const { return m_didApply; }
52 52
53 private: 53 private:
54 FormatBlockCommand(Document&, const QualifiedName& tagName); 54 FormatBlockCommand(Document&, const QualifiedName& tagName);
55 55
56 void formatSelection(const VisiblePosition& startOfSelection, const VisibleP osition& endOfSelection); 56 virtual void formatSelection(const VisiblePosition& startOfSelection, const VisiblePosition& endOfSelection) OVERRIDE;
57 void formatRange(const Position& start, const Position& end, const Position& endOfSelection, RefPtr<Element>&); 57 virtual void formatRange(const Position& start, const Position& end, const P osition& endOfSelection, RefPtr<Element>&) OVERRIDE;
58 EditAction editingAction() const { return EditActionFormatBlock; } 58 virtual EditAction editingAction() const OVERRIDE { return EditActionFormatB lock; }
59 59
60 bool m_didApply; 60 bool m_didApply;
61 }; 61 };
62 62
63 } // namespace WebCore 63 } // namespace WebCore
64 64
65 #endif // FormatBlockCommand_h 65 #endif // FormatBlockCommand_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698