Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1343403004: Remove WebNode::remove(). (Closed)

Created:
5 years, 3 months ago by esprehn
Modified:
5 years, 3 months ago
Reviewers:
pdr., dglazkov
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Remove WebNode::remove(). The only user was inside blink in WebFrameTest and we can just use the real Node::remove() there. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202467

Patch Set 1 #

Patch Set 2 : types. #

Patch Set 3 : rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebNode.cpp View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 4 chunks +10 lines, -3 lines 0 comments Download
M public/web/WebNode.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 20 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343403004/1
5 years, 3 months ago (2015-09-17 08:23:47 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/114400)
5 years, 3 months ago (2015-09-17 08:39:28 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343403004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343403004/20001
5 years, 3 months ago (2015-09-17 08:56:41 UTC) #6
esprehn
5 years, 3 months ago (2015-09-17 09:38:10 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-17 10:14:25 UTC) #10
dglazkov
lgtm
5 years, 3 months ago (2015-09-17 14:34:16 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343403004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343403004/20001
5 years, 3 months ago (2015-09-17 16:39:48 UTC) #13
commit-bot: I haz the power
Failed to apply patch for Source/web/WebNode.cpp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
5 years, 3 months ago (2015-09-17 16:49:23 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343403004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343403004/40001
5 years, 3 months ago (2015-09-17 17:38:17 UTC) #19
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 20:11:27 UTC) #20
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202467

Powered by Google App Engine
This is Rietveld 408576698