Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1343403002: Adding Compiler configs to iOS. (Closed)

Created:
5 years, 3 months ago by sherouk
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@components_bookmarks_bomp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adding Compiler configs to iOS. BUG=459705 Committed: https://crrev.com/a1b18778642e62768180ba000ed60dcb5feca8e9 Cr-Commit-Position: refs/heads/master@{#349482}

Patch Set 1 #

Patch Set 2 : re-parenting branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (6 generated)
sherouk
Can you review please?
5 years, 3 months ago (2015-09-16 13:39:59 UTC) #2
sdefresne
lgtm However I notice that this is a dependent CL on 1310513006. Maybe you should ...
5 years, 3 months ago (2015-09-16 13:42:55 UTC) #3
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-16 21:08:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343403002/20001
5 years, 3 months ago (2015-09-17 09:32:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/100927)
5 years, 3 months ago (2015-09-17 09:41:28 UTC) #9
sdefresne
brettw: you're approval is required due to the no-parent annotation on BUILDCONFIG.gn in build/config/OWNERS. Thank ...
5 years, 3 months ago (2015-09-17 10:11:33 UTC) #11
brettw
lgtm
5 years, 3 months ago (2015-09-17 19:48:12 UTC) #12
sdefresne
lgtm
5 years, 3 months ago (2015-09-17 20:16:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343403002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343403002/20001
5 years, 3 months ago (2015-09-17 20:16:59 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-17 20:23:10 UTC) #16
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 20:24:42 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a1b18778642e62768180ba000ed60dcb5feca8e9
Cr-Commit-Position: refs/heads/master@{#349482}

Powered by Google App Engine
This is Rietveld 408576698