tools/gyp/find_mac_gcc_version.py - Issue 1343393004: SDK gyp: support Xcode V7

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gyp/find_mac_gcc_version.py

Issue 1343393004: SDK gyp: support Xcode V7 (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: cl feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gyp/find_mac_gcc_version.py

diff --git a/tools/gyp/find_mac_gcc_version.py b/tools/gyp/find_mac_gcc_version.py

index 40670ec49b4173f08e6da1c914a77d01fba93916..e7d0f10c6e4d32c42c5ecdaa763e36861e0a7057 100755

--- a/tools/gyp/find_mac_gcc_version.py

+++ b/tools/gyp/find_mac_gcc_version.py

@@ -25,7 +25,7 @@ def main():

return '4.2'

elif major == 4 and minor < 5:

return 'com.apple.compilers.llvmgcc42'

- elif (major == 4 and minor >= 5) or major == 5 or major == 6:

+ elif (major == 4 and minor >= 5) or major => 5:

Paul Berry 2015/09/22 12:38:47 This is a syntax error. I think you mean ">=" ins

# XCode seems to select the specific clang version automatically

return 'com.apple.compilers.llvm.clang.1_0'

else:

« no previous file with comments | « no previous file | no next file » | no next file with comments »