Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 1343383003: VM: Store edge counters in one per-function array. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: clean up comments, save space in IL Instruction class. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler_arm.cc
diff --git a/runtime/vm/flow_graph_compiler_arm.cc b/runtime/vm/flow_graph_compiler_arm.cc
index 5781c29fd76bdbbc8776da1b2703058578411ad8..85d8c38a6472acaafe456097e278c444a13ca404 100644
--- a/runtime/vm/flow_graph_compiler_arm.cc
+++ b/runtime/vm/flow_graph_compiler_arm.cc
@@ -1197,44 +1197,31 @@ void FlowGraphCompiler::GenerateRuntimeCall(intptr_t token_pos,
}
-void FlowGraphCompiler::EmitEdgeCounter() {
+void FlowGraphCompiler::EmitEdgeCounter(intptr_t edge_id) {
// We do not check for overflow when incrementing the edge counter. The
// function should normally be optimized long before the counter can
// overflow; and though we do not reset the counters when we optimize or
// deoptimize, there is a bound on the number of
// optimization/deoptimization cycles we will attempt.
+ ASSERT(!edge_counters_array_.IsNull());
ASSERT(assembler_->constant_pool_allowed());
const Array& counter = Array::ZoneHandle(zone(), Array::New(1, Heap::kOld));
counter.SetAt(0, Smi::Handle(zone(), Smi::New(0)));
__ Comment("Edge counter");
- __ LoadUniqueObject(R0, counter);
- intptr_t increment_start = assembler_->CodeSize();
+ __ LoadObject(R0, edge_counters_array_);
#if defined(DEBUG)
bool old_use_far_branches = assembler_->use_far_branches();
assembler_->set_use_far_branches(true);
#endif // DEBUG
- __ ldr(IP, FieldAddress(R0, Array::element_offset(0)));
+ __ ldr(IP, FieldAddress(R0, Array::element_offset(edge_id)));
__ add(IP, IP, Operand(Smi::RawValue(1)));
- __ StoreIntoSmiField(FieldAddress(R0, Array::element_offset(0)), IP);
- int32_t size = assembler_->CodeSize() - increment_start;
- if (isolate()->edge_counter_increment_size() == -1) {
- isolate()->set_edge_counter_increment_size(size);
- } else {
- ASSERT(size == isolate()->edge_counter_increment_size());
- }
+ __ StoreIntoSmiField(FieldAddress(R0, Array::element_offset(edge_id)), IP);
#if defined(DEBUG)
assembler_->set_use_far_branches(old_use_far_branches);
#endif // DEBUG
}
-int32_t FlowGraphCompiler::EdgeCounterIncrementSizeInBytes() {
- const int32_t size = Isolate::Current()->edge_counter_increment_size();
- ASSERT(size != -1);
- return size;
-}
-
-
void FlowGraphCompiler::EmitOptimizedInstanceCall(
const StubEntry& stub_entry,
const ICData& ic_data,

Powered by Google App Engine
This is Rietveld 408576698