Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Unified Diff: runtime/vm/instructions_mips_test.cc

Issue 1343373003: Revert "VM: New calling convention for generated code." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/instructions_mips.cc ('k') | runtime/vm/instructions_x64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/instructions_mips_test.cc
diff --git a/runtime/vm/instructions_mips_test.cc b/runtime/vm/instructions_mips_test.cc
index cf2f7f2f380e10eca01f75be249989a984200325..a165485294a66d24cd67851b661d01a956235b86 100644
--- a/runtime/vm/instructions_mips_test.cc
+++ b/runtime/vm/instructions_mips_test.cc
@@ -27,10 +27,42 @@ ASSEMBLER_TEST_RUN(Call, test) {
// return jump.
CallPattern call(test->entry() + test->code().Size() - (2*Instr::kInstrSize),
test->code());
- EXPECT_EQ(StubCode::InvokeDartCode_entry()->code(), call.TargetCode());
+ EXPECT_EQ(StubCode::InvokeDartCode_entry()->label().address(),
+ call.TargetAddress());
}
+ASSEMBLER_TEST_GENERATE(Jump, assembler) {
+ __ BranchPatchable(*StubCode::InvokeDartCode_entry());
+ __ BranchPatchable(*StubCode::AllocateArray_entry());
+}
+
+
+ASSEMBLER_TEST_RUN(Jump, test) {
+ const Code& code = test->code();
+ const Instructions& instrs = Instructions::Handle(code.instructions());
+ bool status =
+ VirtualMemory::Protect(reinterpret_cast<void*>(instrs.EntryPoint()),
+ instrs.size(),
+ VirtualMemory::kReadWrite);
+ EXPECT(status);
+ JumpPattern jump1(test->entry(), test->code());
+ EXPECT_EQ(StubCode::InvokeDartCode_entry()->label().address(),
+ jump1.TargetAddress());
+ JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(),
+ test->code());
+ const Code& array_stub =
+ Code::Handle(StubCode::AllocateArray_entry()->code());
+ EXPECT_EQ(array_stub.EntryPoint(), jump2.TargetAddress());
+ uword target1 = jump1.TargetAddress();
+ uword target2 = jump2.TargetAddress();
+ jump1.SetTargetAddress(target2);
+ jump2.SetTargetAddress(target1);
+ EXPECT_EQ(array_stub.EntryPoint(), jump1.TargetAddress());
+ EXPECT_EQ(StubCode::InvokeDartCode_entry()->label().address(),
+ jump2.TargetAddress());
+}
+
} // namespace dart
#endif // defined TARGET_ARCH_MIPS
« no previous file with comments | « runtime/vm/instructions_mips.cc ('k') | runtime/vm/instructions_x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698