Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: runtime/vm/instructions_mips_test.cc

Issue 1343373003: Revert "VM: New calling convention for generated code." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/instructions_mips.cc ('k') | runtime/vm/instructions_x64.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" 5 #include "vm/globals.h"
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/assembler.h" 8 #include "vm/assembler.h"
9 #include "vm/instructions.h" 9 #include "vm/instructions.h"
10 #include "vm/stub_code.h" 10 #include "vm/stub_code.h"
11 #include "vm/unit_test.h" 11 #include "vm/unit_test.h"
12 12
13 namespace dart { 13 namespace dart {
14 14
15 #define __ assembler-> 15 #define __ assembler->
16 16
17 ASSEMBLER_TEST_GENERATE(Call, assembler) { 17 ASSEMBLER_TEST_GENERATE(Call, assembler) {
18 __ BranchLinkPatchable(*StubCode::InvokeDartCode_entry()); 18 __ BranchLinkPatchable(*StubCode::InvokeDartCode_entry());
19 __ Ret(); 19 __ Ret();
20 } 20 }
21 21
22 22
23 ASSEMBLER_TEST_RUN(Call, test) { 23 ASSEMBLER_TEST_RUN(Call, test) {
24 // The return address, which must be the address of an instruction contained 24 // The return address, which must be the address of an instruction contained
25 // in the code, points to the Ret instruction above, i.e. two instructions 25 // in the code, points to the Ret instruction above, i.e. two instructions
26 // before the end of the code buffer, including the delay slot for the 26 // before the end of the code buffer, including the delay slot for the
27 // return jump. 27 // return jump.
28 CallPattern call(test->entry() + test->code().Size() - (2*Instr::kInstrSize), 28 CallPattern call(test->entry() + test->code().Size() - (2*Instr::kInstrSize),
29 test->code()); 29 test->code());
30 EXPECT_EQ(StubCode::InvokeDartCode_entry()->code(), call.TargetCode()); 30 EXPECT_EQ(StubCode::InvokeDartCode_entry()->label().address(),
31 call.TargetAddress());
31 } 32 }
32 33
33 34
35 ASSEMBLER_TEST_GENERATE(Jump, assembler) {
36 __ BranchPatchable(*StubCode::InvokeDartCode_entry());
37 __ BranchPatchable(*StubCode::AllocateArray_entry());
38 }
39
40
41 ASSEMBLER_TEST_RUN(Jump, test) {
42 const Code& code = test->code();
43 const Instructions& instrs = Instructions::Handle(code.instructions());
44 bool status =
45 VirtualMemory::Protect(reinterpret_cast<void*>(instrs.EntryPoint()),
46 instrs.size(),
47 VirtualMemory::kReadWrite);
48 EXPECT(status);
49 JumpPattern jump1(test->entry(), test->code());
50 EXPECT_EQ(StubCode::InvokeDartCode_entry()->label().address(),
51 jump1.TargetAddress());
52 JumpPattern jump2(test->entry() + jump1.pattern_length_in_bytes(),
53 test->code());
54 const Code& array_stub =
55 Code::Handle(StubCode::AllocateArray_entry()->code());
56 EXPECT_EQ(array_stub.EntryPoint(), jump2.TargetAddress());
57 uword target1 = jump1.TargetAddress();
58 uword target2 = jump2.TargetAddress();
59 jump1.SetTargetAddress(target2);
60 jump2.SetTargetAddress(target1);
61 EXPECT_EQ(array_stub.EntryPoint(), jump1.TargetAddress());
62 EXPECT_EQ(StubCode::InvokeDartCode_entry()->label().address(),
63 jump2.TargetAddress());
64 }
65
34 } // namespace dart 66 } // namespace dart
35 67
36 #endif // defined TARGET_ARCH_MIPS 68 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/instructions_mips.cc ('k') | runtime/vm/instructions_x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698