Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Side by Side Diff: runtime/vm/instructions_ia32.h

Issue 1343373003: Revert "VM: New calling convention for generated code." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/instructions_arm_test.cc ('k') | runtime/vm/instructions_ia32_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // Classes that describe assembly patterns as used by inline caches. 4 // Classes that describe assembly patterns as used by inline caches.
5 5
6 #ifndef VM_INSTRUCTIONS_IA32_H_ 6 #ifndef VM_INSTRUCTIONS_IA32_H_
7 #define VM_INSTRUCTIONS_IA32_H_ 7 #define VM_INSTRUCTIONS_IA32_H_
8 8
9 #ifndef VM_INSTRUCTIONS_H_ 9 #ifndef VM_INSTRUCTIONS_H_
10 #error Do not include instructions_ia32.h directly; use instructions.h instead. 10 #error Do not include instructions_ia32.h directly; use instructions.h instead.
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
97 return kCallPattern; 97 return kCallPattern;
98 } 98 }
99 99
100 private: 100 private:
101 static const int kLengthInBytes = 5; 101 static const int kLengthInBytes = 5;
102 102
103 DISALLOW_COPY_AND_ASSIGN(CallPattern); 103 DISALLOW_COPY_AND_ASSIGN(CallPattern);
104 }; 104 };
105 105
106 106
107 class JumpPattern : public CallOrJumpPattern<JumpPattern> {
108 public:
109 JumpPattern(uword pc, const Code& code) : CallOrJumpPattern(pc) {}
110
111 static int pattern_length_in_bytes() { return kLengthInBytes; }
112 static const int* pattern() {
113 static const int kJumpPattern[kLengthInBytes] = {0xE9, -1, -1, -1, -1};
114 return kJumpPattern;
115 }
116
117 private:
118 static const int kLengthInBytes = 5;
119
120 DISALLOW_COPY_AND_ASSIGN(JumpPattern);
121 };
122
123
107 class ReturnPattern : public InstructionPattern<ReturnPattern> { 124 class ReturnPattern : public InstructionPattern<ReturnPattern> {
108 public: 125 public:
109 explicit ReturnPattern(uword pc) : InstructionPattern(pc) {} 126 explicit ReturnPattern(uword pc) : InstructionPattern(pc) {}
110 127
111 static const int* pattern() { 128 static const int* pattern() {
112 static const int kReturnPattern[kLengthInBytes] = { 0xC3 }; 129 static const int kReturnPattern[kLengthInBytes] = { 0xC3 };
113 return kReturnPattern; 130 return kReturnPattern;
114 } 131 }
115 static int pattern_length_in_bytes() { return kLengthInBytes; } 132 static int pattern_length_in_bytes() { return kLengthInBytes; }
116 133
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
150 167
151 static int pattern_length_in_bytes() { return kLengthInBytes; } 168 static int pattern_length_in_bytes() { return kLengthInBytes; }
152 169
153 private: 170 private:
154 static const int kLengthInBytes = 2; 171 static const int kLengthInBytes = 2;
155 }; 172 };
156 173
157 } // namespace dart 174 } // namespace dart
158 175
159 #endif // VM_INSTRUCTIONS_IA32_H_ 176 #endif // VM_INSTRUCTIONS_IA32_H_
OLDNEW
« no previous file with comments | « runtime/vm/instructions_arm_test.cc ('k') | runtime/vm/instructions_ia32_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698