[Interpreter] Basic flow control.

src/interpreter/bytecodes.h

Index: src/interpreter/bytecodes.h
diff --git a/src/interpreter/bytecodes.h b/src/interpreter/bytecodes.h
index f4756516f16f874c248f266af95e32582fd2d829..adff359a6fa2038f83b1aa4de699a959bcdf7e6d 100644
--- a/src/interpreter/bytecodes.h
+++ b/src/interpreter/bytecodes.h
@@ -58,7 +58,25 @@ namespace interpreter {
   /* Call operations. */                                                   \
   V(Call, OperandType::kReg, OperandType::kReg, OperandType::kCount)       \
                                                                            \
+  /* Test Operators */                                                     \
+  V(TestEqual, OperandType::kReg)                                          \
+  V(TestNotEqual, OperandType::kReg)                                       \
+  V(TestEqualStrict, OperandType::kReg)                                    \
+  V(TestNotEqualStrict, OperandType::kReg)                                 \
+  V(TestLessThan, OperandType::kReg)                                       \
+  V(TestGreaterThan, OperandType::kReg)                                    \
+  V(TestLessThanEqual, OperandType::kReg)                                  \
+  V(TestGreaterThanEqual, OperandType::kReg)                               \
+  V(TestInstanceOf, OperandType::kReg)                                     \
+  V(TestIn, OperandType::kReg)                                             \
+                                                                           \
   /* Control Flow */                                                       \
+  V(JumpSmi8, OperandType::kImm8)                                          \

[rmcilroy, 2015/09/18 10:42:23]

This is not really a Smi, it is just an imm8. How about we just remove the
suffix from these (e.g., Jump, JumpIfTrue, etc.) since they are expected to be
the normal case?

[oth, 2015/09/23 10:46:56]

Done.

+  V(JumpConstant, OperandType::kIdx)                                       \
+  V(JumpIfTrueSmi8, OperandType::kImm8)                                    \

[rmcilroy, 2015/09/18 10:42:24]

As discussed, you aren't using JumpIfTrue yet except for tests. Could you add a
TODO here to remove it if we don't need it after implementing the other control
flow constructs.

[oth, 2015/09/23 10:46:56]

do...while() is a prime candidate for JumpIfTrue.

+  V(JumpIfTrueConstant, OperandType::kIdx)                                 \
+  V(JumpIfFalseSmi8, OperandType::kImm8)                                   \
+  V(JumpIfFalseConstant, OperandType::kIdx)                                \

[rmcilroy, 2015/09/18 10:42:23]

optional super nit - I would prefer ordered by operand type, i.e.:
Jump
JumpIfTrue
JumpIfFalse
JumpConstant...

[oth, 2015/09/23 10:46:56]

The current ordering groups by functionality like many asm references. The code
here doesn't have to match that, but I'd prefer not to churn the declaration and
implementation in this CL.

   V(Return, OperandType::kNone)