[Interpreter] Basic flow control.

src/interpreter/bytecodes.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_INTERPRETER_BYTECODES_H_
 #define V8_INTERPRETER_BYTECODES_H_
 
 #include <iosfwd>
 
 // Clients of this interface shouldn't depend on lots of interpreter internals.
@@ skipping 40 matching lines @@
   /* Binary Operators */                                                   \
   V(Add, OperandType::kReg)                                                \
   V(Sub, OperandType::kReg)                                                \
   V(Mul, OperandType::kReg)                                                \
   V(Div, OperandType::kReg)                                                \
   V(Mod, OperandType::kReg)                                                \
                                                                            \
   /* Call operations. */                                                   \
   V(Call, OperandType::kReg, OperandType::kReg, OperandType::kCount)       \
                                                                            \
+  /* Test Operators */                                                     \
+  V(TestEqual, OperandType::kReg)                                          \
+  V(TestNotEqual, OperandType::kReg)                                       \
+  V(TestEqualStrict, OperandType::kReg)                                    \
+  V(TestNotEqualStrict, OperandType::kReg)                                 \
+  V(TestLessThan, OperandType::kReg)                                       \
+  V(TestGreaterThan, OperandType::kReg)                                    \
+  V(TestLessThanEqual, OperandType::kReg)                                  \
+  V(TestGreaterThanEqual, OperandType::kReg)                               \
+  V(TestInstanceOf, OperandType::kReg)                                     \
+  V(TestIn, OperandType::kReg)                                             \
+                                                                           \
   /* Control Flow */                                                       \
+  V(JumpSmi8, OperandType::kImm8)                                          \

[rmcilroy, 2015/09/18 10:42:23]

This is not really a Smi, it is just an imm8. How about we just remove the
suffix from these (e.g., Jump, JumpIfTrue, etc.) since they are expected to be
the normal case?

[oth, 2015/09/23 10:46:56]

Done.

+  V(JumpConstant, OperandType::kIdx)                                       \
+  V(JumpIfTrueSmi8, OperandType::kImm8)                                    \

[rmcilroy, 2015/09/18 10:42:24]

As discussed, you aren't using JumpIfTrue yet except for tests. Could you add a
TODO here to remove it if we don't need it after implementing the other control
flow constructs.

[oth, 2015/09/23 10:46:56]

do...while() is a prime candidate for JumpIfTrue.

+  V(JumpIfTrueConstant, OperandType::kIdx)                                 \
+  V(JumpIfFalseSmi8, OperandType::kImm8)                                   \
+  V(JumpIfFalseConstant, OperandType::kIdx)                                \

[rmcilroy, 2015/09/18 10:42:23]

optional super nit - I would prefer ordered by operand type, i.e.:
Jump
JumpIfTrue
JumpIfFalse
JumpConstant...

[oth, 2015/09/23 10:46:56]

The current ordering groups by functionality like many asm references. The code
here doesn't have to match that, but I'd prefer not to churn the declaration and
implementation in this CL.

   V(Return, OperandType::kNone)
 
 
 // Enumeration of operand types used by bytecodes.
 enum class OperandType : uint8_t {
 #define DECLARE_OPERAND_TYPE(Name) k##Name,
   OPERAND_TYPE_LIST(DECLARE_OPERAND_TYPE)
 #undef DECLARE_OPERAND_TYPE
 #define COUNT_OPERAND_TYPES(x) +1
   // The COUNT_OPERAND macro will turn this into kLast = -1 +1 +1... which will
@@ skipping 91 matching lines @@
 };
 
 std::ostream& operator<<(std::ostream& os, const Bytecode& bytecode);
 std::ostream& operator<<(std::ostream& os, const OperandType& operand_type);
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_INTERPRETER_BYTECODES_H_