[Interpreter] Basic flow control.

src/compiler/interpreter-assembler.h

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef V8_COMPILER_INTERPRETER_ASSEMBLER_H_
 #define V8_COMPILER_INTERPRETER_ASSEMBLER_H_
 
 // Clients of this interface shouldn't depend on lots of compiler internals.
 // Do not include anything from src/compiler here!
 #include "src/allocation.h"
 #include "src/base/smart-pointers.h"
 #include "src/builtins.h"
 #include "src/frames.h"
 #include "src/interpreter/bytecodes.h"
 #include "src/runtime/runtime.h"
+#include "src/zone-containers.h"
 
 namespace v8 {
 namespace internal {
 
 class CallInterfaceDescriptor;
 class Isolate;
 class Zone;
 
 namespace compiler {
 
@@ skipping 35 matching lines @@
 
   // Returns the location in memory of the register |reg_index| in the
   // interpreter register file.
   Node* RegisterLocation(Node* reg_index);
 
   // Constants.
   Node* Int32Constant(int value);
   Node* IntPtrConstant(intptr_t value);
   Node* NumberConstant(double value);
   Node* HeapConstant(Handle<HeapObject> object);
+  Node* BooleanConstant(bool value);
 
   // Tag and untag Smi values.
   Node* SmiTag(Node* value);
   Node* SmiUntag(Node* value);
 
   // Basic arithmetic operations.
   Node* IntPtrAdd(Node* a, Node* b);
   Node* IntPtrSub(Node* a, Node* b);
   Node* WordShl(Node* value, int shift);
 
@@ skipping 18 matching lines @@
 
   // Call an IC code stub.
   Node* CallIC(CallInterfaceDescriptor descriptor, Node* target, Node* arg1,
                Node* arg2, Node* arg3, Node* arg4);
   Node* CallIC(CallInterfaceDescriptor descriptor, Node* target, Node* arg1,
                Node* arg2, Node* arg3, Node* arg4, Node* arg5);
 
   // Call runtime function.
   Node* CallRuntime(Runtime::FunctionId function_id, Node* arg1, Node* arg2);
 
+  // Jump relative to the current bytecode by |jump_offset|.
+  void Jump(Node* jump_offset);

[rmcilroy, 2015/09/18 10:42:23]

please add tests for these in interpreter-assembler-unittests please.

[oth, 2015/09/23 10:46:55]

Added a test for Jump and a partial test JumpIfWordEqual. Going to try
mstarzinger's approach to JumpIfWordEqual first and then revise the latter test.

+
+  // Jump relative to the current bytecode by |jump_offset| if the
+  // values |lhs| and |rhs| are equal.
+  void JumpIfEqual(Node* lhs, Node* rhs, Node* jump_offset);
+
+  // Jump relative to the current bytecode by |jump_offset| if the
+  // values |lhs| and |rhs| are not equal.
+  void JumpIfNotEqual(Node* lhs, Node* rhs, Node* jump_offset);
+
   // Returns from the function.
   void Return();
 
   // Dispatch to the bytecode.
   void Dispatch();
 
  protected:
   // Close the graph.
   void End();
 
@@ skipping 20 matching lines @@
   Node* BytecodeOperand(int operand_index);
   Node* BytecodeOperandSignExtended(int operand_index);
 
   Node* CallIC(CallInterfaceDescriptor descriptor, Node* target, Node** args);
   Node* CallJSBuiltin(int context_index, Node* receiver, Node** js_args,
                       int js_arg_count);
 
   // Returns BytecodeOffset() advanced by delta bytecodes. Note: this does not
   // update BytecodeOffset() itself.
   Node* Advance(int delta);
+  Node* Advance(Node* delta);
 
-  // Sets the end node of the graph.
-  void SetEndInput(Node* input);
+  // Starts next instruction dispatch at |new_bytecode_offset|.
+  void DispatchTo(Node* new_bytecode_offset);
+
+  // Adds an end node of the graph.
+  void AddEndInput(Node* input);
 
   // Private helpers which delegate to RawMachineAssembler.
   Isolate* isolate();
   Schedule* schedule();
   Zone* zone();
 
   interpreter::Bytecode bytecode_;
   base::SmartPointer<RawMachineAssembler> raw_assembler_;
-  Node* end_node_;
+  ZoneVector<Node*> end_nodes_;
   Node* accumulator_;
   bool code_generated_;
 
   DISALLOW_COPY_AND_ASSIGN(InterpreterAssembler);
 };
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8
 
 #endif  // V8_COMPILER_INTERPRETER_ASSEMBLER_H_