Clean up some A64 specific code in common code that was introduced by A64 merge

src/checks.h

 // Copyright 2012 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 16 matching lines @@
 
 #ifndef V8_CHECKS_H_
 #define V8_CHECKS_H_
 
 #include <string.h>
 
 #include "../include/v8stdint.h"
 
 extern "C" void V8_Fatal(const char* file, int line, const char* format, ...);
 
-// Define custom A64 preprocessor helpers to facilitate development.
-#ifndef V8_TARGET_ARCH_A64
 
 // The FATAL, UNREACHABLE and UNIMPLEMENTED macros are useful during
 // development, but they should not be relied on in the final product.
 #ifdef DEBUG
 #define FATAL(msg)                              \
   V8_Fatal(__FILE__, __LINE__, "%s", (msg))
 #define UNIMPLEMENTED()                         \
   V8_Fatal(__FILE__, __LINE__, "unimplemented code")
 #define UNREACHABLE()                           \
   V8_Fatal(__FILE__, __LINE__, "unreachable code")
 #else
 #define FATAL(msg)                              \
   V8_Fatal("", 0, "%s", (msg))
 #define UNIMPLEMENTED()                         \
   V8_Fatal("", 0, "unimplemented code")
 #define UNREACHABLE() ((void) 0)
 #endif
 
+// Simulator specific helpers.
+#if defined(USE_SIMULATOR) && defined(V8_TARGET_ARCH_A64)
+  // TODO(all): If possible automatically prepend an indicator like
+  // UNIMPLEMENTED or LOCATION.
+  #define ASM_UNIMPLEMENTED(message)                                         \
+  __ Debug(message, __LINE__, NO_PARAM)
+  #define ASM_UNIMPLEMENTED_BREAK(message)                                   \
+  __ Debug(message, __LINE__,                                                \
+           FLAG_ignore_asm_unimplemented_break ? NO_PARAM : BREAK)
+  #define ASM_LOCATION(message)                                              \
+  __ Debug("LOCATION: " message, __LINE__, NO_PARAM)
 #else
-
-  #ifdef DEBUG
-    #define FATAL(msg)                                                         \
-      V8_Fatal(__FILE__, __LINE__, "%s", (msg))
-    #define UNREACHABLE()                                                      \
-      V8_Fatal(__FILE__, __LINE__, "unreachable code")
-    #else
-    #define FATAL(msg)                                                         \
-      V8_Fatal("", 0, "%s", (msg))
-    #define UNREACHABLE() ((void) 0)
-  #endif
-
-  #define ABORT() printf("in %s, line %i, %s", __FILE__, __LINE__, __func__); \
-    abort()
-
-  #define ALIGNMENT_EXCEPTION() printf("ALIGNMENT EXCEPTION\t"); ABORT()
-
-  // Helpers for unimplemented sections.
-  #define UNIMPLEMENTED()                                                      \
-    do {                                                                       \
-      printf("UNIMPLEMENTED: %s, line %d, %s\n",                               \
-             __FILE__, __LINE__, __func__);                                    \
-      V8_Fatal(__FILE__, __LINE__, "unimplemented code");                      \
-    } while (0)
-  #define UNIMPLEMENTED_M(message)                                             \
-    do {                                                                       \
-      printf("UNIMPLEMENTED: %s, line %d, %s : %s\n",                          \
-             __FILE__, __LINE__, __func__, message);                           \
-      V8_Fatal(__FILE__, __LINE__, "unimplemented code");                      \
-    } while (0)
-  // Like UNIMPLEMENTED, but does not abort.
-  #define TODO_UNIMPLEMENTED(message)                                          \
-      do {                                                                     \
-        static const unsigned int kLimit = 1;                                  \
-        static unsigned int printed = 0;                                       \
-        if (printed < UINT_MAX) {                                              \
-          printed++;                                                           \
-        }                                                                      \
-        if (printed <= kLimit) {                                               \
-          printf("UNIMPLEMENTED: %s, line %d, %s: %s\n",                       \
-                 __FILE__, __LINE__, __func__, message);                       \
-        }                                                                      \
-      } while (0)
-
-  // Simulator specific helpers.
-  #ifdef USE_SIMULATOR
-    // Helpers for unimplemented sections.
-    // TODO(all): If possible automatically prepend an indicator like
-    // UNIMPLEMENTED or LOCATION.
-    #define ASM_UNIMPLEMENTED(message)                                         \
-    __ Debug(message, __LINE__, NO_PARAM)
-    #define ASM_UNIMPLEMENTED_BREAK(message)                                   \
-    __ Debug(message, __LINE__,                                                \
-             FLAG_ignore_asm_unimplemented_break ? NO_PARAM : BREAK)
-    #define ASM_LOCATION(message)                                              \
-    __ Debug("LOCATION: " message, __LINE__, NO_PARAM)
-  #else
-    #define ASM_UNIMPLEMENTED(message)
-    #define ASM_UNIMPLEMENTED_BREAK(message)
-    #define ASM_LOCATION(message)
-  #endif
-
+  #define ASM_UNIMPLEMENTED(message)
+  #define ASM_UNIMPLEMENTED_BREAK(message)
+  #define ASM_LOCATION(message)
 #endif
 
 
 // The CHECK macro checks that the given condition is true; if not, it
 // prints a message to stderr and aborts.
 #define CHECK(condition) do {                                       \
     if (!(condition)) {                                             \
       V8_Fatal(__FILE__, __LINE__, "CHECK(%s) failed", #condition); \
     }                                                               \
   } while (0)
@@ skipping 260 matching lines @@
 
 // "Extra checks" are lightweight checks that are enabled in some release
 // builds.
 #ifdef ENABLE_EXTRA_CHECKS
 #define EXTRA_CHECK(condition) CHECK(condition)
 #else
 #define EXTRA_CHECK(condition) ((void) 0)
 #endif
 
 #endif  // V8_CHECKS_H_