Issue 134333011: Clean up some A64 specific code in common code that was introduced by A64 merge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 134333011: Clean up some A64 specific code in common code that was introduced by A64 merge (Closed)

Created:
6 years, 10 months ago by rmcilroy

Modified:
6 years, 10 months ago

Reviewers:
ulan, Rodolph Perfetta (ARM)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Clean up some A64 specific code in common code that was introduced by A64 merge - Remove arch specific check macros - Remove duplicate code in code-stubs.h - Remove flag check in bootstrap.cc which was introduced for A64 bringup - Remove A64 specific test message expectations R=rodolph.perfetta@arm.com, ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=19325

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+23 lines, -98 lines)			Patch
M	src/a64/simulator-a64.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/a64/simulator-a64.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	src/checks.h	View	2 chunks	+14 lines, -64 lines	0 comments	Download
M	src/code-stubs.h	View	1 chunk	+1 line, -7 lines	0 comments	Download
M	test/message/message.status	View	1 chunk	+0 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rmcilroy

6 years, 10 months ago (2014-02-12 13:27:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19325 (presubmit successful).

Expand Messages | Collapse Messages