Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(935)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 134333008: Allow 'continue' URL to match even if redirected to another Google TLD. (Closed)

Created:
6 years, 11 months ago by bcwhite
Modified:
6 years, 11 months ago
CC:
chromium-reviews, tim+watch_chromium.org, rsimha+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Allow 'continue' URL to match even if redirected to another Google TLD. BUG=333869 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245332

Patch Set 1 #

Patch Set 2 : allow subdomains off google.com for continue URLs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -7 lines) Patch
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 1 chunk +15 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
bcwhite
6 years, 11 months ago (2014-01-14 16:09:10 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm
6 years, 11 months ago (2014-01-14 16:53:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/134333008/1
6 years, 11 months ago (2014-01-14 17:32:02 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=246105
6 years, 11 months ago (2014-01-14 20:22:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/134333008/1
6 years, 11 months ago (2014-01-16 15:03:59 UTC) #5
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=212575
6 years, 11 months ago (2014-01-16 15:58:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/134333008/480001
6 years, 11 months ago (2014-01-16 17:28:29 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247400
6 years, 11 months ago (2014-01-16 18:05:08 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/134333008/480001
6 years, 11 months ago (2014-01-16 18:33:01 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 21:36:52 UTC) #10
Message was sent while issue was closed. 
Change committed as 245332

Powered by Google App Engine
This is Rietveld 408576698