Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1343303003: Revert of Mandoline: Add WebGL support (Closed)

Created:
5 years, 3 months ago by Dirk Pranke
Modified:
5 years, 3 months ago
Reviewers:
Fady Samuel, Peng, sky, piman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Mandoline: Add WebGL support (patchset #9 id:180001 of https://codereview.chromium.org/1338433002/ ) Reason for revert: Unfortunately, this broke `gn check` with an improper dependency. http://build.chromium.org/p/chromium.linux/builders/Linux%20GN/builds/32063/steps/gn_check/logs/stdio I have a patch in-flight that will re-enable gn check on the trybots so that this breakages don't get through, but in the meantime I'm reverting this. Sorry! Original issue's description: > This change adds WebGL support in mandoline. It also adds GL > chromium_framebuffer_multisample extension which is need by > WebGL. > > TODO: > * Pass attributes to GPU when create WebGL context. > * Get GPU info and fill it into glinfo. > > TEST= mandoline --enable-webgl http://learningwebgl.com/lessons/lesson03/index.html > BUG=525159 > NOPRESUBMIT=true > > Committed: https://crrev.com/ab7a90daddbe7d44558d8703b12204570ae98431 > Cr-Commit-Position: refs/heads/master@{#349206} TBR=sky@chromium.org,piman@chromium.org,fsamuel@chromium.org,penghuang@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=525159 Committed: https://crrev.com/c6374e2ea63356bd00853ae2dde9b4bcdb204a92 Cr-Commit-Position: refs/heads/master@{#349226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -352 lines) Patch
M components/html_viewer/BUILD.gn View 3 chunks +0 lines, -4 lines 0 comments Download
M components/html_viewer/DEPS View 2 chunks +0 lines, -3 lines 0 comments Download
M components/html_viewer/blink_platform_impl.h View 2 chunks +0 lines, -12 lines 0 comments Download
M components/html_viewer/blink_platform_impl.cc View 4 chunks +1 line, -32 lines 0 comments Download
M components/html_viewer/html_widget.cc View 3 chunks +0 lines, -7 lines 0 comments Download
D components/html_viewer/web_graphics_context_3d_command_buffer_impl.h View 1 chunk +0 lines, -61 lines 0 comments Download
D components/html_viewer/web_graphics_context_3d_command_buffer_impl.cc View 1 chunk +0 lines, -63 lines 0 comments Download
M components/mus/gles2/command_buffer_driver.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 5 chunks +1 line, -8 lines 0 comments Download
M mojo/gles2/gles2_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/gpu/mojo_gles2_impl_autogen.cc View 3 chunks +2 lines, -7 lines 0 comments Download
M mojo/runner/native_application_support.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M third_party/mojo/src/mojo/public/c/gles2/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D third_party/mojo/src/mojo/public/c/gles2/chromium_framebuffer_multisample.h View 1 chunk +0 lines, -30 lines 0 comments Download
D third_party/mojo/src/mojo/public/c/gles2/gles2_call_visitor_chromium_framebuffer_multisample_autogen.h View 1 chunk +0 lines, -32 lines 0 comments Download
M third_party/mojo/src/mojo/public/platform/native/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/mojo/src/mojo/public/platform/native/gles2_impl_chromium_framebuffer_multisample_thunks.h View 1 chunk +0 lines, -47 lines 0 comments Download
D third_party/mojo/src/mojo/public/platform/native/gles2_impl_chromium_framebuffer_multisample_thunks.cc View 1 chunk +0 lines, -34 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dirk Pranke
Created Revert of Mandoline: Add WebGL support
5 years, 3 months ago (2015-09-16 20:54:05 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343303003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343303003/1
5 years, 3 months ago (2015-09-16 20:54:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-16 20:56:42 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-16 20:57:27 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c6374e2ea63356bd00853ae2dde9b4bcdb204a92
Cr-Commit-Position: refs/heads/master@{#349226}

Powered by Google App Engine
This is Rietveld 408576698