Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 13433007: Update scoped_array<T>::reset logic to match scoped_ptr. (Closed)

Created:
7 years, 8 months ago by dcheng
Modified:
7 years, 8 months ago
Reviewers:
Mark Mentovai, brettw
CC:
chromium-reviews, erikwright+watch_chromium.org, gavinp+memory_chromium.org
Visibility:
Public.

Description

Update scoped_array<T>::reset logic to match scoped_ptr. This logic was already added in scoped_ptr::reset() in https://src.chromium.org/viewvc/chrome?view=rev&revision=185551. this is a straightforward port of the logic to scoped_array to prevent any accidental regressions during the transition. BUG=162971, 176091 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192590

Patch Set 1 #

Patch Set 2 : Fix dumb typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -8 lines) Patch
M base/memory/scoped_ptr.h View 1 1 chunk +10 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
7 years, 8 months ago (2013-04-05 05:43:10 UTC) #1
dcheng
Mark, mind reviewing this patch so I can get this landed? In practice, I don't ...
7 years, 8 months ago (2013-04-05 16:27:20 UTC) #2
Mark Mentovai
LGTM
7 years, 8 months ago (2013-04-05 17:15:43 UTC) #3
dcheng
7 years, 8 months ago (2013-04-05 17:18:58 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r192590 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698