content/content_browser.gypi - Issue 13433002: Implement DeviceOrientation API on Windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/content_browser.gypi

Issue 13433002: Implement DeviceOrientation API on Windows (Closed) Base URL: ssh://nhu@powerbuilder.sh.intel.com/home/www-data/git-repos/perc/chromium.git@sensor

Patch Set: Update according to sail's and peter's comments #8, #9 and #11 Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/content_browser.gypi

diff --git a/content/content_browser.gypi b/content/content_browser.gypi

index bf67cedd32ff4dfe98144cfa10f6d8768f3e8e72..c61c16bb4c6feb20a0bbde642c09fc70f63a1c34 100644

--- a/content/content_browser.gypi

+++ b/content/content_browser.gypi

@@ -341,6 +341,8 @@

'browser/device_orientation/data_fetcher.h',

'browser/device_orientation/data_fetcher_impl_android.cc',

'browser/device_orientation/data_fetcher_impl_android.h',

+ 'browser/device_orientation/data_fetcher_impl_win.cc',

+ 'browser/device_orientation/data_fetcher_impl_win.h',

'browser/device_orientation/device_data.h',

'browser/device_orientation/message_filter.cc',

'browser/device_orientation/message_filter.h',

@@ -1108,6 +1110,7 @@

'-ldinput8.lib',

'-llocationapi.lib',

'-lsensorsapi.lib',

+ '-lportabledeviceguids.lib',

sail 2013/04/09 20:53:53 How big is this lib? Can we avoid using this and j

nhu 2013/04/10 09:46:42 On my windows kits, it is 504KB. If we don't use i

sail 2013/04/10 17:00:10 Unfortunately that's too big. I think you can fix

'msvs_settings': {

'VCLinkerTool': {

« content/browser/device_orientation/data_fetcher_impl_win.cc ('K') | « content/browser/device_orientation/provider_impl.cc ('k') | no next file » | no next file with comments »