chrome/browser/renderer_host/safe_browsing_resource_throttle.cc - Issue 1343293004: Don't check URLs against Safe Browsing if not supported.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/renderer_host/safe_browsing_resource_throttle.cc

Issue 1343293004: Don't check URLs against Safe Browsing if not supported. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rm extraneous comment Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/renderer_host/safe_browsing_resource_throttle.cc

diff --git a/chrome/browser/renderer_host/safe_browsing_resource_throttle.cc b/chrome/browser/renderer_host/safe_browsing_resource_throttle.cc

index c7d53516635fa6964e38cfc745dd53d965a14acd..332ee837cf917fa3884af6d62bfe51106e7940f6 100644

--- a/chrome/browser/renderer_host/safe_browsing_resource_throttle.cc

+++ b/chrome/browser/renderer_host/safe_browsing_resource_throttle.cc

@@ -63,7 +63,8 @@ SafeBrowsingResourceThrottle* SafeBrowsingResourceThrottle::MaybeCreate(

request, resource_type, sb_service, DEFER_AT_START,

SafeBrowsingService::CHECK_ALL_RESOURCE_TYPES);

#elif defined(SAFE_BROWSING_DB_REMOTE)

- if (!sb_service->IsAndroidFieldTrialEnabled())

+ if (!sb_service->IsAndroidFieldTrialEnabled() ||

+ !sb_service->database_manager()->IsSupported())

return nullptr;

Lei Zhang 2015/09/22 20:36:22 nit: wrap this in {} when the if statement is mult

Nathan Parker 2015/09/22 20:40:49 Done.

// Throttle consults a remote database before processing the response.

« no previous file with comments | « build/config/features.gni ('k') | chrome/browser/safe_browsing/database_manager.h » ('j') | no next file with comments »