Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1343283003: Mandoline: Fix PackageManager initialization (Closed)

Created:
5 years, 3 months ago by Fady Samuel
Modified:
5 years, 3 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, penghuang+watch-mandoline_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mandoline: Fix PackageManager initialization This was causing a crash at startup. BUG= TBR=ben@chromium.org Committed: https://crrev.com/6fd88cb9373aaf3b8a314f0013580c2e4a791e46 Cr-Commit-Position: refs/heads/master@{#349421}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M mandoline/app/desktop/launcher_process.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/runner/context.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Fady Samuel
PTAL. The PackageManager refactor broke Mandoline launch.
5 years, 3 months ago (2015-09-17 14:55:58 UTC) #2
Fady Samuel
TBR'ing + CQ'ing
5 years, 3 months ago (2015-09-17 15:05:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343283003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343283003/1
5 years, 3 months ago (2015-09-17 15:05:12 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-17 15:16:56 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 15:17:34 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6fd88cb9373aaf3b8a314f0013580c2e4a791e46
Cr-Commit-Position: refs/heads/master@{#349421}

Powered by Google App Engine
This is Rietveld 408576698