Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: src/IceELFObjectWriter.cpp

Issue 1343283002: Subzero: Remove an unwanted assert. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceELFObjectWriter.cpp
diff --git a/src/IceELFObjectWriter.cpp b/src/IceELFObjectWriter.cpp
index 25c2bf3aebb48acece2797e5268b1cd65ff50a0f..9e1d44ed7352f2567ca82910ed6a03616d96b18c 100644
--- a/src/IceELFObjectWriter.cpp
+++ b/src/IceELFObjectWriter.cpp
@@ -605,7 +605,9 @@ void ELFObjectWriter::setUndefinedSyms(const ConstantList &UndefSyms) {
Ctx.getIntrinsicsInfo().find(Name, BadIntrinsic);
if (Info)
continue;
- assert(!BadIntrinsic);
+ // Ignore BadIntrinsic, which is set if the name begins with "llvm." but
+ // doesn't match a known intrinsic. If we want this to turn into an error,
+ // we should catch it early on.
assert(Sym->getOffset() == 0);
assert(Sym->getSuppressMangling());
SymTab->noteUndefinedSym(Name, NullSection);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698