Issue 1343283002: Subzero: Remove an unwanted assert.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1343283002: Subzero: Remove an unwanted assert. (Closed)

Created:
5 years, 3 months ago by Jim Stichnoth

Modified:
5 years, 3 months ago

Reviewers:
Karl, ascull, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Remove an unwanted assert. At the end, the ELF emitter code marks all the external symbols that are undefined in this object file, but it filters intrinsics out of this set. Previously, it was asserting on a "bad intrinsic", meaning a function whose name starts with "llvm." but doesn't match a known intrinsic. The assert doesn't really make sense here. Either it should be more strongly validated early on in the translation, or it should just pass through (and the link will probably fail, or maybe not). BUG= https://code.google.com/p/nativeclient/issues/detail?id=4319 R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=def0482dc40f46e2462d39a3d961722fd5c60b52

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	src/IceELFObjectWriter.cpp	View		1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

5 years, 3 months ago (2015-09-16 18:27:09 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
def0482dc40f46e2462d39a3d961722fd5c60b52 (presubmit successful).