Fix for issue 24243 (allow objects of dart:core and dart:collections to be passed in for now, we ne…

runtime/vm/snapshot.cc

Index: runtime/vm/snapshot.cc
diff --git a/runtime/vm/snapshot.cc b/runtime/vm/snapshot.cc
index decc5a78071d7136ea72a2d67673ee177c26d7c2..cbbf890e1825fa6bb2abf081d6c42c5b1788a289 100644
--- a/runtime/vm/snapshot.cc
+++ b/runtime/vm/snapshot.cc
@@ -2646,7 +2646,9 @@ void SnapshotWriter::WriteInstanceRef(RawObject* raw, RawClass* cls) {
 
 
 bool SnapshotWriter::AllowObjectsInDartLibrary(RawLibrary* library) {
-  return library == object_store()->typed_data_library();
+  return (library == object_store()->collection_library() ||

[koda, 2015/09/16 17:41:26]

I don't think the whitelisting of dart.collection is being exercised by your
tests, since both Map and List are in the dart.core library. You could simply
add a test with an explicit LinkedHashMap type argument.

[siva, 2015/09/16 18:24:44]

Added a new test with the type being expicitly set to a LinkedHashMap

+          library == object_store()->core_library() ||
+          library == object_store()->typed_data_library());
 }