tools/testing/dart/test_progress.dart - Issue 13432003: Fixed test_progress to print the failure summary even if no stepname was given

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/testing/dart/test_progress.dart

Issue 13432003: Fixed test_progress to print the failure summary even if no stepname was given (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/testing/dart/test_progress.dart

diff --git a/tools/testing/dart/test_progress.dart b/tools/testing/dart/test_progress.dart

index 773321746121a98932eee4574e604cfa08376491..4589b8da75ad317c1500629c4b641c6b1c9fa8a6 100644

--- a/tools/testing/dart/test_progress.dart

+++ b/tools/testing/dart/test_progress.dart

@@ -504,9 +504,11 @@ class BuildbotProgressIndicator extends ProgressIndicator {

}

void allDone() {

- if (!_failureSummary.isEmpty && stepName != null) {

+ if (!_failureSummary.isEmpty) {

print('@@@STEP_FAILURE@@@');

- print('@@@BUILD_STEP $stepName failures@@@');

+ if (stepName != null) {

+ print('@@@BUILD_STEP $stepName failures@@@');

+ }

for (String line in _failureSummary) {

print(line);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »