skia: Add support for ANGLE on linux

skia: Add support for ANGLE on linux

This will allow the ANGLE guys to test the ANGLE gl backend
with nanobench and DM

Committed: https://skia.googlesource.com/skia/+/6f0fdac9e7248c4e82ba2c9f6331694db0174bb2

[hendrikw, 2015-09-16 18:48:01]

The CQ bit was checked by hendrikw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-16 18:48:14]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1343193005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1343193005/20001

[commit-bot: I haz the power, 2015-09-16 18:48:15]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-09-17 00:48 UTC

[hendrikw, 2015-09-16 20:06:08]

The CQ bit was checked by hendrikw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-16 20:06:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1343193005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1343193005/40001

[hendrikw, 2015-09-16 20:47:02]

hendrikw@chromium.org changed reviewers:
+ bsalomon@google.com

[hendrikw, 2015-09-16 20:47:02]

PTAL

I'm not so happy about the gyp changes.


Requires: GYP_DEFINES=skia_angle=1 use_x11=1 chromeos=0

I couldn't figure out how to conditionally set use_x11=1 and chromeos=0 when
skia_angle==1.  (I can if it isn't conditional)

[bsalomon, 2015-09-21 12:57:09]

Hm, I don't think I know gyp well enough to help you with that :)

lgtm. I will file a bug to get a bot running with this.

https://codereview.chromium.org/1343193005/diff/80001/gyp/common.gypi
File gyp/common.gypi (right):

https://codereview.chromium.org/1343193005/diff/80001/gyp/common.gypi#newcode34
gyp/common.gypi:34: 'error': '<!(skia_angle=1 only supported with skia_os="win"
or skia_ok="linux".)',
skia_os?

[mtklein, 2015-09-21 13:02:56]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-09-21 13:02:57]

https://codereview.chromium.org/1343193005/diff/80001/gyp/common_conditions.gypi
File gyp/common_conditions.gypi (right):

https://codereview.chromium.org/1343193005/diff/80001/gyp/common_conditions.g...
gyp/common_conditions.gypi:255: '-fstrict-aliasing',
Can we not just turn off this stuff for ANGLE?  Anything in this file is global.

[hendrikw, 2015-09-21 16:54:01]

On 2015/09/21 13:02:57, mtklein wrote:
>
https://codereview.chromium.org/1343193005/diff/80001/gyp/common_conditions.gypi
> File gyp/common_conditions.gypi (right):
> 
>
https://codereview.chromium.org/1343193005/diff/80001/gyp/common_conditions.g...
> gyp/common_conditions.gypi:255: '-fstrict-aliasing',
> Can we not just turn off this stuff for ANGLE?  Anything in this file is
global.

I tried, but gyp files...

I'll try asking around, see if I can find someone who know how to get this
working.

[charlieloveeric3, 2015-09-22 09:41:32]

charlieloveeric3@gmail.com changed reviewers:
+ charlieloveeric3@gmail.com
- bsalomon@google.com, mtklein@google.com

[charlieloveeric3, 2015-09-22 09:41:33]

More information on android-libhost-dev_21-4_amd64.deb:
Exact Size	11586 Byte (11.3 kByte)
MD5 checksum	cddd47b5ab68898f62841d6bebfcaab1
SHA1 checksum	9ce64d2674d0da7f5a1dd00880b84a120d081303
SHA256 checksum	86b46bf426d8953d28968c9033bbe19f9e709cc5839b128724312ef6750cc85d

[hendrikw, 2015-09-22 22:41:18]

On 2015/09/21 16:54:01, hendrikw wrote:
> On 2015/09/21 13:02:57, mtklein wrote:
> >
>
https://codereview.chromium.org/1343193005/diff/80001/gyp/common_conditions.gypi
> > File gyp/common_conditions.gypi (right):
> > 
> >
>
https://codereview.chromium.org/1343193005/diff/80001/gyp/common_conditions.g...
> > gyp/common_conditions.gypi:255: '-fstrict-aliasing',
> > Can we not just turn off this stuff for ANGLE?  Anything in this file is
> global.
> 
> I tried, but gyp files...
> 
> I'll try asking around, see if I can find someone who know how to get this
> working.

So, gyp files are the suck.  After speaking with Dirk for a while, it looks like
the only way to get this working is to modify ANGLE.

Basically, global flags are global, and there's no way to pass flags to other
projects.

I'll look into updating ANGLE.

[mtklein, 2015-09-23 10:28:45]

On 2015/09/22 22:41:18, hendrikw wrote:
> On 2015/09/21 16:54:01, hendrikw wrote:
> > On 2015/09/21 13:02:57, mtklein wrote:
> > >
> >
>
https://codereview.chromium.org/1343193005/diff/80001/gyp/common_conditions.gypi
> > > File gyp/common_conditions.gypi (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1343193005/diff/80001/gyp/common_conditions.g...
> > > gyp/common_conditions.gypi:255: '-fstrict-aliasing',
> > > Can we not just turn off this stuff for ANGLE?  Anything in this file is
> > global.
> > 
> > I tried, but gyp files...
> > 
> > I'll try asking around, see if I can find someone who know how to get this
> > working.
> 
> So, gyp files are the suck.  After speaking with Dirk for a while, it looks
like
> the only way to get this working is to modify ANGLE.
> 
> Basically, global flags are global, and there's no way to pass flags to other
> projects.
> 
> I'll look into updating ANGLE.

Thanks for digging in.  Let's not let GYP block landing this.  Perhaps for now,
can you just add a note that says something like,
   # We'd want to set these only inside angle.gyp, but, well, we can't figure
out how to do that or if it's even possible.
?

[hendrikw, 2015-09-23 15:32:45]

On 2015/09/23 10:28:45, mtklein wrote:
> On 2015/09/22 22:41:18, hendrikw wrote:
> > On 2015/09/21 16:54:01, hendrikw wrote:
> > > On 2015/09/21 13:02:57, mtklein wrote:
> > > >
> > >
> >
>
https://codereview.chromium.org/1343193005/diff/80001/gyp/common_conditions.gypi
> > > > File gyp/common_conditions.gypi (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/1343193005/diff/80001/gyp/common_conditions.g...
> > > > gyp/common_conditions.gypi:255: '-fstrict-aliasing',
> > > > Can we not just turn off this stuff for ANGLE?  Anything in this file is
> > > global.
> > > 
> > > I tried, but gyp files...
> > > 
> > > I'll try asking around, see if I can find someone who know how to get this
> > > working.
> > 
> > So, gyp files are the suck.  After speaking with Dirk for a while, it looks
> like
> > the only way to get this working is to modify ANGLE.
> > 
> > Basically, global flags are global, and there's no way to pass flags to
other
> > projects.
> > 
> > I'll look into updating ANGLE.
> 
> Thanks for digging in.  Let's not let GYP block landing this.  Perhaps for
now,
> can you just add a note that says something like,
>    # We'd want to set these only inside angle.gyp, but, well, we can't figure
> out how to do that or if it's even possible.
> ?

Yeah, makes sense. I have a fix for angle (I think), for now I'll land this,
then update angle, roll it, and then remove the angle specific gyp changes.

[hendrikw, 2015-09-23 17:00:15]

The CQ bit was checked by hendrikw@chromium.org

[hendrikw, 2015-09-23 17:00:16]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/1343193005/#ps120002
(title: "who knows, gyp makes no sense.")

[commit-bot: I haz the power, 2015-09-23 17:00:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1343193005/120002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1343193005/120002

[hendrikw, 2015-09-23 17:06:54]

On 2015/09/23 17:00:30, commit-bot: I haz the power wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1343193005/120002
> View timeline at
>  https://chromium-cq-status.appspot.com/patch-timeline/1343193005/120002

oops, I forgot to add the comment to the gyp file, I'll try to get it removed
soon...

[cwallez, 2015-09-23 17:15:42]

On 2015/09/23 17:06:54, hendrikw wrote:
> On 2015/09/23 17:00:30, commit-bot: I haz the power wrote:
> > CQ is trying da patch. Follow status at
> >  https://chromium-cq-status.appspot.com/patch-status/1343193005/120002
> > View timeline at
> >  https://chromium-cq-status.appspot.com/patch-timeline/1343193005/120002
> 
> oops, I forgot to add the comment to the gyp file, I'll try to get it removed
> soon...

LGTM up to the gyp files, most of it can be moved in ANGLE (and we'll fix the
warnings)

[commit-bot: I haz the power, 2015-09-23 18:36:01]

Committed patchset #10 (id:120002) as
https://skia.googlesource.com/skia/+/6f0fdac9e7248c4e82ba2c9f6331694db0174bb2