Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1343163005: Remove special pagination code for floats and out-of-flow objects. (Closed)

Created:
5 years, 3 months ago by mstensho (USE GERRIT)
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remove special pagination code for floats and out-of-flow objects. This got added years ago, to make something work, either for CSS regions or for the old multicol implementation. I see no need for this code, and it was getting in my way. R=jchaffraix@chromium.org,leviw@chromium.org Committed: https://crrev.com/828fe0b1b2fa4328d891d00153c7637ae99a75b4 git-svn-id: svn://svn.chromium.org/blink/trunk@202351 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -25 lines) Patch
M Source/core/layout/LayoutBlock.cpp View 1 chunk +0 lines, -16 lines 0 comments Download
M Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +1 line, -7 lines 0 comments Download
M Source/core/layout/LayoutState.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
mstensho (USE GERRIT)
5 years, 3 months ago (2015-09-16 12:31:47 UTC) #1
Julien - ping for review
lgtm
5 years, 3 months ago (2015-09-16 15:43:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343163005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343163005/1
5 years, 3 months ago (2015-09-16 15:43:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202351
5 years, 3 months ago (2015-09-16 15:48:47 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:56:19 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/828fe0b1b2fa4328d891d00153c7637ae99a75b4

Powered by Google App Engine
This is Rietveld 408576698