Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 1343123002: Convert unit tests, GMs from SkBitmapSource to SkImagesource (Closed)

Created:
5 years, 3 months ago by f(malita)
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Convert unit tests, GMs from SkBitmapSource to SkImagesource This removes SkBitmapSource clients within Skia. http://crrev.com/1334173004 does the same for Blink, so we should be able to remove SkBitmapSource in a follow-up. R=reed@google.com,robertphillips@google.com,mtklein@google.com Committed: https://skia.googlesource.com/skia/+/5598b63cd2443a608a74a222d0206bb2455383b7

Patch Set 1 #

Total comments: 20

Patch Set 2 : review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -416 lines) Patch
M bench/DisplacementBench.cpp View 6 chunks +20 lines, -15 lines 0 comments Download
M bench/MergeBench.cpp View 1 2 chunks +21 lines, -20 lines 0 comments Download
D gm/bitmapsource2.cpp View 1 chunk +0 lines, -89 lines 0 comments Download
M gm/displacement.cpp View 5 chunks +19 lines, -12 lines 0 comments Download
M gm/imagefiltersclipped.cpp View 6 chunks +14 lines, -13 lines 0 comments Download
M gm/imagefilterscropexpand.cpp View 1 5 chunks +84 lines, -81 lines 0 comments Download
M gm/imagefiltersgraph.cpp View 1 6 chunks +17 lines, -15 lines 0 comments Download
M gm/imagefiltersscaled.cpp View 1 4 chunks +30 lines, -27 lines 0 comments Download
A + gm/imagesource2.cpp View 5 chunks +20 lines, -16 lines 0 comments Download
M gm/offsetimagefilter.cpp View 1 3 chunks +40 lines, -37 lines 0 comments Download
M gm/resizeimagefilter.cpp View 2 chunks +9 lines, -7 lines 0 comments Download
M gm/tileimagefilter.cpp View 5 chunks +28 lines, -27 lines 0 comments Download
M gm/xfermodeimagefilter.cpp View 1 10 chunks +39 lines, -34 lines 0 comments Download
M samplecode/SampleFilterFuzz.cpp View 3 chunks +6 lines, -3 lines 0 comments Download
M tests/ImageFilterTest.cpp View 1 8 chunks +20 lines, -17 lines 0 comments Download
M tests/SerializationTest.cpp View 2 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343123002/1
5 years, 3 months ago (2015-09-15 17:08:49 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 17:14:47 UTC) #4
f(malita)
5 years, 3 months ago (2015-09-15 17:15:09 UTC) #5
robertphillips
lgtm https://codereview.chromium.org/1343123002/diff/1/bench/MergeBench.cpp File bench/MergeBench.cpp (right): https://codereview.chromium.org/1343123002/diff/1/bench/MergeBench.cpp#newcode66 bench/MergeBench.cpp:66: SkAutoTUnref<SkSurface> surface(SkSurface::NewRasterN32Premul(80, 80)); "SkCanvas* canvas = surface->getCanvas();" here ...
5 years, 3 months ago (2015-09-15 17:43:52 UTC) #6
f(malita)
https://codereview.chromium.org/1343123002/diff/1/bench/MergeBench.cpp File bench/MergeBench.cpp (right): https://codereview.chromium.org/1343123002/diff/1/bench/MergeBench.cpp#newcode66 bench/MergeBench.cpp:66: SkAutoTUnref<SkSurface> surface(SkSurface::NewRasterN32Premul(80, 80)); On 2015/09/15 17:43:52, robertphillips wrote: > ...
5 years, 3 months ago (2015-09-15 18:12:54 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343123002/20001
5 years, 3 months ago (2015-09-15 18:12:59 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-15 18:19:06 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1343123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1343123002/20001
5 years, 3 months ago (2015-09-15 18:25:19 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-15 18:26:19 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5598b63cd2443a608a74a222d0206bb2455383b7

Powered by Google App Engine
This is Rietveld 408576698