Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 13431009: Add xxxFloat() methods to WebMediaPlayer implementations. (Closed)

Created:
7 years, 8 months ago by acolwell GONE FROM CHROMIUM
Modified:
7 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add xxxFloat() methods to WebMediaPlayer implementations. These methods will be used to transition the corresponding WebMediaPlayer methods from using floats to using doubles instead. BUG=227156 TEST=All tests pass. No change in functionality. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192902

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+128 lines, -8 lines) Patch
M webkit/media/android/webmediaplayer_android.h View 3 chunks +8 lines, -0 lines 0 comments Download
M webkit/media/android/webmediaplayer_android.cc View 5 chunks +32 lines, -0 lines 0 comments Download
M webkit/media/webmediaplayer_impl.h View 3 chunks +8 lines, -0 lines 0 comments Download
M webkit/media/webmediaplayer_impl.cc View 8 chunks +32 lines, -0 lines 0 comments Download
M webkit/media/webmediaplayer_ms.h View 3 chunks +16 lines, -8 lines 0 comments Download
M webkit/media/webmediaplayer_ms.cc View 4 chunks +32 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
acolwell GONE FROM CHROMIUM
This is the Chromium-side changes I need to land before landing the Blink change (https://codereview.chromium.org/13454026/) ...
7 years, 8 months ago (2013-04-06 01:59:01 UTC) #1
scherkus (not reviewing)
lgtm
7 years, 8 months ago (2013-04-08 14:49:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/13431009/2001
7 years, 8 months ago (2013-04-08 14:59:29 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 15:07:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/13431009/2001
7 years, 8 months ago (2013-04-08 16:15:50 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 8 months ago (2013-04-08 16:20:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/13431009/2001
7 years, 8 months ago (2013-04-08 21:05:12 UTC) #7
commit-bot: I haz the power
7 years, 8 months ago (2013-04-08 21:27:26 UTC) #8
Message was sent while issue was closed.
Change committed as 192902

Powered by Google App Engine
This is Rietveld 408576698