[heap] Move slots buffer into a separate file.

[heap] Move slots buffer into a separate file.

BUG=

Committed: https://crrev.com/064be4c2964a94fb03ff32b531a9fcd7e73aac89
Cr-Commit-Position: refs/heads/master@{#30746}

[Hannes Payer (out of office), 2015-09-15 09:42:52]

hpayer@chromium.org changed reviewers:
+ mlippautz@chromium.org, mstarzinger@chromium.org

[Hannes Payer (out of office), 2015-09-15 09:42:53]

https://codereview.chromium.org/1343043002/diff/1/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (left):

https://codereview.chromium.org/1343043002/diff/1/src/heap/mark-compact.cc#ol...
src/heap/mark-compact.cc:3472: static bool IsOnInvalidatedCodeObject(Address
addr) {
unused.

https://codereview.chromium.org/1343043002/diff/1/src/heap/mark-compact.cc#ol...
src/heap/mark-compact.cc:4638: void SlotsBuffer::UpdateSlotsWithFilter(Heap*
heap) {
Unused.

[Hannes Payer (out of office), 2015-09-15 10:46:25]

Patchset #5 (id:80001) has been deleted

[Michael Starzinger, 2015-09-15 11:00:51]

LGTM (assuming there are no semantic changes to the function bodies).

https://codereview.chromium.org/1343043002/diff/40001/src/heap/slots-buffer.h
File src/heap/slots-buffer.h (right):

https://codereview.chromium.org/1343043002/diff/40001/src/heap/slots-buffer.h...
src/heap/slots-buffer.h:5: #ifndef V8_SLOTS_BUFFER_H_
nit: V8_HEAP_SLOTS_BUFFER_H_ here.

https://codereview.chromium.org/1343043002/diff/40001/src/heap/slots-buffer.h...
src/heap/slots-buffer.h:188: #endif  // V8_SLOTS_BUFFER_H_
nit: V8_HEAP_SLOTS_BUFFER_H_ here.

[Michael Lippautz, 2015-09-15 11:04:02]

lgtm

https://codereview.chromium.org/1343043002/diff/40001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1343043002/diff/40001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:62: slots_buffer_allocator_(NULL),
nullptr

https://codereview.chromium.org/1343043002/diff/40001/test/cctest/test-slots-...
File test/cctest/test-slots-buffer.cc (right):

https://codereview.chromium.org/1343043002/diff/40001/test/cctest/test-slots-...
test/cctest/test-slots-buffer.cc:8: using v8::Just;
Remove, as there's no caller left.

https://codereview.chromium.org/1343043002/diff/40001/test/cctest/test-slots-...
test/cctest/test-slots-buffer.cc:12: 
-line

[Hannes Payer (out of office), 2015-09-15 11:20:48]

https://codereview.chromium.org/1343043002/diff/40001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/1343043002/diff/40001/src/heap/mark-compact.c...
src/heap/mark-compact.cc:62: slots_buffer_allocator_(NULL),
On 2015/09/15 11:04:02, Michael Lippautz wrote:
> nullptr

Done.

https://codereview.chromium.org/1343043002/diff/40001/src/heap/slots-buffer.h
File src/heap/slots-buffer.h (right):

https://codereview.chromium.org/1343043002/diff/40001/src/heap/slots-buffer.h...
src/heap/slots-buffer.h:5: #ifndef V8_SLOTS_BUFFER_H_
On 2015/09/15 11:00:50, Michael Starzinger wrote:
> nit: V8_HEAP_SLOTS_BUFFER_H_ here.

Done.

https://codereview.chromium.org/1343043002/diff/40001/src/heap/slots-buffer.h...
src/heap/slots-buffer.h:188: #endif  // V8_SLOTS_BUFFER_H_
On 2015/09/15 11:00:50, Michael Starzinger wrote:
> nit: V8_HEAP_SLOTS_BUFFER_H_ here.

Done.

https://codereview.chromium.org/1343043002/diff/40001/test/cctest/test-slots-...
File test/cctest/test-slots-buffer.cc (right):

https://codereview.chromium.org/1343043002/diff/40001/test/cctest/test-slots-...
test/cctest/test-slots-buffer.cc:8: using v8::Just;
On 2015/09/15 11:04:02, Michael Lippautz wrote:
> Remove, as there's no caller left.

Done.

https://codereview.chromium.org/1343043002/diff/40001/test/cctest/test-slots-...
test/cctest/test-slots-buffer.cc:12: 
On 2015/09/15 11:04:02, Michael Lippautz wrote:
> -line

Done.

[Hannes Payer (out of office), 2015-09-15 11:20:52]

The CQ bit was checked by hpayer@chromium.org

[Hannes Payer (out of office), 2015-09-15 11:20:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
mlippautz@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/1343043002/#ps100001
(title: " ")

[commit-bot: I haz the power, 2015-09-15 11:20:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1343043002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1343043002/100001

[commit-bot: I haz the power, 2015-09-15 12:35:09]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2015-09-15 12:35:29]

Patchset 5 (id:??) landed as
https://crrev.com/064be4c2964a94fb03ff32b531a9fcd7e73aac89
Cr-Commit-Position: refs/heads/master@{#30746}